From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: gnus / message-send-mail-with-mailclient [patch] Date: Thu, 9 Feb 2006 12:06:50 +0000 Message-ID: <059BF802-B4EB-433E-AF78-024107CD7E16@gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v746.2) Content-Type: multipart/mixed; boundary="===============1239013740==" X-Trace: sea.gmane.org 1139505007 21722 80.91.229.2 (9 Feb 2006 17:10:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 9 Feb 2006 17:10:07 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 09 18:09:58 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F7FGa-0001PM-2V for ged-emacs-devel@m.gmane.org; Thu, 09 Feb 2006 18:07:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F7FFu-0007oL-2m for ged-emacs-devel@m.gmane.org; Thu, 09 Feb 2006 12:06:54 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F7Bu7-0004GS-Aw for emacs-devel@gnu.org; Thu, 09 Feb 2006 08:32:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F7BCt-0005dE-Pk for emacs-devel@gnu.org; Thu, 09 Feb 2006 07:47:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F7AZa-0007By-IX for emacs-devel@gnu.org; Thu, 09 Feb 2006 07:06:55 -0500 Original-Received: from [66.249.92.207] (helo=uproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F7Ad7-0003VM-EJ for emacs-devel@gnu.org; Thu, 09 Feb 2006 07:10:33 -0500 Original-Received: by uproxy.gmail.com with SMTP id q2so172019uge for ; Thu, 09 Feb 2006 04:06:52 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:mime-version:to:message-id:content-type:from:subject:date:x-mailer; b=KrhxaiJ/pc+xVL9ziclJO5iMLfi5hfNsmYcmKEyxAw6zf+NstkZHyQqDLXKWOzEPy17f1+JxrXK8XnA9Oc6vHhQds4T/XK3+fkvGdtACUJbFCDnASXMtDgvnRLWfZwxl1kuA+ZEdm1K+Y/acA2PSn7XFtYLAYi+eXVVqhVSENwM= Original-Received: by 10.66.184.5 with SMTP id h5mr981908ugf; Thu, 09 Feb 2006 04:06:52 -0800 (PST) Original-Received: from ?129.215.174.81? ( [129.215.174.81]) by mx.gmail.com with ESMTP id q1sm360013uge.2006.02.09.04.06.48; Thu, 09 Feb 2006 04:06:48 -0800 (PST) Original-To: Emacs-Devel ' X-Mailer: Apple Mail (2.746.2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50242 Archived-At: --===============1239013740== Content-Type: multipart/signed; micalg=sha1; boundary=Apple-Mail-43-118337170; protocol="application/pkcs7-signature" --Apple-Mail-43-118337170 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed The send-mail-function defined specifically for the message package doesn't work on systems where no sendmail is running. That's why we added the `mailclient' package a while ago. The patch below fixes the problem analogous to what has been done in the `sendmail' package. I noticed this when `reporter' didn't successfully send off e-mails. Are there any other places where sendmail functionality is assumed, but `send-mail-function' is not respected? *** lisp/gnus/message.el 04 Feb 2006 18:25:51 +0000 1.101 --- lisp/gnus/message.el 09 Feb 2006 12:01:32 +0000 *************** *** 584,599 **** :link '(custom-manual "(message)Canceling News") :type 'string) ;; Useful to set in site-init.el ;;;###autoload (defcustom message-send-mail-function 'message-send-mail-with- sendmail "Function to call to send the current buffer as mail. The headers should be delimited by a line whose contents match the variable `mail-header-separator'. ! Valid values include `message-send-mail-with-sendmail' (the default), `message-send-mail-with-mh', `message-send-mail-with-qmail', ! `message-smtpmail-send-it', `smtpmail-send-it' and `feedmail-send-it'. See also `send-mail-function'." :type '(radio (function-item message-send-mail-with-sendmail) --- 584,609 ---- :link '(custom-manual "(message)Canceling News") :type 'string) + ;; Prevent problems with `window-system' not having the correct value + ;; when loaddefs.el is loaded. `custom-reevaluate-setting' needs the + ;; standard value. + ;;;###autoload + (put 'message-send-mail-function 'standard-value + '((if (and window-system (memq system-type '(darwin windows-nt))) + 'message-send-mail-with-mailclient + 'message-send-mail-with-sendmail))) + ;; Useful to set in site-init.el ;;;###autoload (defcustom message-send-mail-function 'message-send-mail-with- sendmail "Function to call to send the current buffer as mail. The headers should be delimited by a line whose contents match the variable `mail-header-separator'. ! Valid values include `message-send-mail-with-sendmail' (the default), `message-send-mail-with-mh', `message-send-mail-with-qmail', ! `message-smtpmail-send-it', `smtpmail-send-it', `feedmail-send-it' ! and `message-send-mail-with-mailclient'. See also `send-mail-function'." :type '(radio (function-item message-send-mail-with-sendmail) *************** *** 3982,3987 **** --- 3992,4005 ---- (run-hooks 'message-send-mail-hook) (smtpmail-send-it)) + + (defun message-send-mail-with-mailclient () + "Send the prepared message buffer with `mailclient-send-it'. + This only differs from `smtpmail-send-it' that this command evaluates + `message-send-mail-hook' just before sending a message." + (run-hooks 'message-send-mail-hook) + (mailclient-send-it)) + (defun message-canlock-generate () "Return a string that is non-trivial to guess. Do not use this for anything important, it is cryptographically weak." Index: startup.el =================================================================== RCS file: /sources/emacs/emacs/lisp/startup.el,v retrieving revision 1.397 diff -c -r1.397 startup.el *** lisp/startup.el 22 Jan 2006 23:14:25 -0000 1.397 --- lisp/startup.el 9 Feb 2006 12:02:12 -0000 *************** *** 463,469 **** (if (string-match "^\\(xterm\\|rxvt\\|dtterm\\|eterm\\)" term) (setq default-frame-background-mode 'light))) ! (frame-set-background-mode (selected-frame))))) ;; Now we know the user's default font, so add it to the menu. (if (fboundp 'font-menu-add-default) --- 463,472 ---- (if (string-match "^\\(xterm\\|rxvt\\|dtterm\\|eterm\\)" term) (setq default-frame-background-mode 'light))) ! (frame-set-background-mode (selected-frame)))) ! ! ;; time to make the frame visible (Aquamacs) ! (make-frame-visible)) ;; Now we know the user's default font, so add it to the menu. (if (fboundp 'font-menu-add-default) *************** *** 741,746 **** --- 744,752 ---- (run-hooks 'before-init-hook) + ;; the initial frame is hidden in Aquamacs + (setq initial-frame-alist (cons '(visibility . nil) initial-frame- alist)) + ;; Under X Window, this creates the X frame and deletes the terminal frame. (when (fboundp 'frame-initialize) (frame-initialize)) *************** *** 778,783 **** --- 784,790 ---- (custom-reevaluate-setting 'mouse-wheel-up-event) (custom-reevaluate-setting 'file-name-shadow-mode) (custom-reevaluate-setting 'send-mail-function) + (custom-reevaluate-setting 'message-send-mail-function) ;; Register default TTY colors for the case the terminal hasn't a ;; terminal init file. *************** *** 1828,1833 **** --- 1835,1843 ---- (when (fboundp 'frame-notice-user-settings) (frame-notice-user-settings)) + ;; time to make the frame visible (Aquamacs) + (make-frame-visible) + ;; If there are no switches to process, we might as well ;; run this hook now, and there may be some need to do it ;; before doing any output. -- http://aquamacs.org -- Aquamacs: Emacs on Mac OS X http://aquamacs.org/donate -- Could we help you? Return the favor and support the Aquamacs Project! --Apple-Mail-43-118337170 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGSDCCAwEw ggJqoAMCAQICECpBOEPOHM4BejmOP5CCsMQwDQYJKoZIhvcNAQEEBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA1MTIxMjE2MDk1M1oXDTA2MTIxMjE2MDk1 M1owYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIIBIjANBgkqhkiG 9w0BAQEFAAOCAQ8AMIIBCgKCAQEA4bqHoSvkjP7motQjFcJ9zYEU08Kj6RASiq69ESk8MZ/gfShR 1CtN98eHFdcxeDbB8bfDhu7pNuWUZwXX9sRguA5s9i4hiioabPhJBs8RbigN0PFm17+7LRLEtQC5 f5mqXGjl07pMyhnLvcGBaZkovjzHP+tU4ewPU92wTUHAtqyriC3GgdxjOGo3pKBChRD8f7E7TIRj iy8G+SXK1ocQ9AAyAEtcKGNT0twSeGE8zz5GTLpeOrO64legj3doI50p9mhr4Fx0zh8+7Tlpg+KY VWf0x0O5xi5yD8u4Ih31yrydyJTNjXB64ABjDR2g8ElpHTXTYRXtq7KBk7y0Rf311QIDAQABozQw MjAiBgNVHREEGzAZgRdkYXZpZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqG SIb3DQEBBAUAA4GBAKqaMz6cpRGl4OTIGkioqaNfWFpx24fTYNSN0QvvuTqhm/UMIZhojJoA6iUG wp8tVMjVivF4mvrJQrsPNIWgmVyb+iyCo/fEpV2+mcTWZvnF+se3dY/Cb6K14Iz8HHKgNh1p5wZF 4s8GVduxB18HrUPmKh97q/WTLVcWtknevqhoMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUF ADCB0TELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBU b3duMRowGAYDVQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBT ZXJ2aWNlcyBEaXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSsw KQYJKoZIhvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAw MFoXDTEzMDcxNjIzNTk1OVowYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0 aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5n IENBMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7s vc31W/Iadr1/DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV 84J3PQO+K/67GD4Hv0CAAmTXp6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGR MBIGA1UdEwEB/wQIMAYBAf8CAQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUu Y29tL1RoYXd0ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCk HjAcMRowGAYDVQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oL LswNo2asZw9/r6y+whehQ5aUnX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoL gnSeJVCUYsfbJ3FXJY3dqZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHT HUb/XV9lTzGCAxAwggMMAgEBMHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25z dWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1 aW5nIENBAhAqQThDzhzOAXo5jj+QgrDEMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkq hkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTA2MDIwOTEyMDY1MVowIwYJKoZIhvcNAQkEMRYEFIcM HC3ULFsltognXYgaH4a3sse5MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYD VQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29u YWwgRnJlZW1haWwgSXNzdWluZyBDQQIQKkE4Q84czgF6OY4/kIKwxDCBhwYLKoZIhvcNAQkQAgsx eKB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQu MSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQKkE4Q84czgF6 OY4/kIKwxDANBgkqhkiG9w0BAQEFAASCAQCiNobhb0AUcueesAwB0EyDCDNY25x7v+5OWw9Cx4oh c5jRZjo6qwmR4IduCOaLarRY58aWnSQ1toJOS2c2RdWartCDH2IpnqUB6DGAmb5pAt87s/2kU+H8 eqTVb0WZt6V9EB0pWniYWLXs4xhlqgsxeYGpyfGiCslVX24YQj7IcMqcVZxfogNS9CVpLTSR2Pan B0Nmmq1jnTNQAfxcRMIqkNQwqpP+jV63Jek5QU4FPhvcJwuyh2LWYtOFD8KehTfdnN1q391RlKu6 n/x5VY+EaXJ/b096XS1O+2VSqFadQ9xixZ8gxcXA+Rr60BiXxDnzk/sri6Tk/DVuS0uvEi8xAAAA AAAA --Apple-Mail-43-118337170-- --===============1239013740== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1239013740==--