From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: Improvement proposals for `completing-read' Date: Wed, 14 Apr 2021 12:44:47 +0200 Message-ID: <058f35e9-eadc-b2da-a252-d3f02e07f9ba@daniel-mendler.de> References: <09b67fc5-f8fd-c48a-8b0b-ad47c88761f1@yandex.ru> <292a9f63-5a41-7b32-66f2-67d06f138a09@yandex.ru> <7d03e917-6a61-23b3-e735-a8e43c3fb65f@daniel-mendler.de> <01ffe85f-6bdb-39a5-b20a-e3c60bea3e2e@yandex.ru> <759ed5ae-8d58-e73b-244b-08bd86aafb2d@yandex.ru> <000385dc-a234-ade9-584b-c4f515d7b01f@yandex.ru> <8117fc58-4dae-d0b4-43d8-d2e521d1e586@daniel-mendler.de> <9c780787-e205-6344-4cf2-dd67b14db1d9@daniel-mendler.de> <9cf1358c-ad0a-4220-974d-86cf1089f20a@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33534"; mail-complaints-to="usenet@ciao.gmane.io" To: Dmitry Gutov , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 14 12:47:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWd3L-0008dJ-0U for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Apr 2021 12:47:23 +0200 Original-Received: from localhost ([::1]:55814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWd3J-0004fL-Uj for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Apr 2021 06:47:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWd1D-00036P-Ap for emacs-devel@gnu.org; Wed, 14 Apr 2021 06:45:11 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:51903 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWd19-0005ZU-Kq for emacs-devel@gnu.org; Wed, 14 Apr 2021 06:45:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MmyA4Jx9hyLd+lWaGbnoq6yuXSJoJceufrTJ0q2fr6Y=; b=VS+1/ix8ytSNAhRoZMTdbsMtuV m8zYp/kbXPmvLCq57k0RbuA9OJAc/ODzDmlZLNTmIOunnMQ+wh8MiX18dvRiyrD4sgGIoj/9wNb2J xhontQRGycA35GqUIxHpmns8ioR4NUf13sRAC1xnnEl/EK9XgVSkkN0H9tNHHaWjoHhA=; In-Reply-To: <9cf1358c-ad0a-4220-974d-86cf1089f20a@yandex.ru> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268035 Archived-At: On 4/14/21 2:00 AM, Dmitry Gutov wrote: > On 12.04.2021 14:04, Daniel Mendler wrote: >> The `consult--async-sink` contains this code which performs the >> refreshing: >> >>       ;; Refresh the UI when the current minibuffer window belongs >>       ;; to the current asynchronous completion session. >>       (when-let (win (active-minibuffer-window)) >>         (when (eq (window-buffer win) buffer) >>           (with-selected-window win >>             (run-hooks 'consult--completion-refresh-hook))))) > > Sounds good for minibuffers, but not so great for code completion, where > context is more complex. And since completing-read shares the notion of > completion table with completion-at-point-functions, I think any async > support we add should work for both purposes. Yes, that would be good. In order to generalize the Consult async protocol one would have to pass some refresh/notify function during setup, e.g. instead of passing only the 'setup argument, also pass a notify function argument. It seems to me that would be sufficient.