From: Paul Eggert <eggert@cs.ucla.edu>
To: emacs-devel@gnu.org
Subject: Re: Floating-point constant folding in Emacs byte compiler
Date: Mon, 2 Apr 2018 12:20:31 -0700 [thread overview]
Message-ID: <058336f6-1b68-69c5-27ee-13edeb86f636@cs.ucla.edu> (raw)
In-Reply-To: <jwv4lkt3bw0.fsf-monnier+gmane.emacs.devel@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
On 04/02/2018 07:48 AM, Stefan Monnier wrote:
> we're not free to
> merge two strings just because they're `equal`, whereas for floats
> we are.
Yes, that's the key point here. I see that the Elisp documentation does
not specify how eq behaves on floats with the same values, so I took a
crack at specifying this the same way that Common Lisp and Scheme do by
installing the attached into master. I doubt whether Common Lisp/Scheme
semantics here will break real Elisp code in any significant way.
[-- Attachment #2: 0001-Clarify-eq-on-floats.patch --]
[-- Type: text/x-patch, Size: 1333 bytes --]
From b89189f686a599817d8cdcc81038b62a38a7baa7 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 2 Apr 2018 12:19:00 -0700
Subject: [PATCH] Clarify eq on floats
* doc/lispref/objects.texi (Equality Predicates):
Say that two floats with the same values might or might not be eq.
---
doc/lispref/objects.texi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/doc/lispref/objects.texi b/doc/lispref/objects.texi
index af740625ad..78a7dccc88 100644
--- a/doc/lispref/objects.texi
+++ b/doc/lispref/objects.texi
@@ -2083,6 +2083,10 @@ Equality Predicates
necessarily @code{eq} to each other: they are @code{eq} only if they
are the same object, meaning that a change in the contents of one will
be reflected by the same change in the contents of the other.
+For other types of objects whose contents cannot be changed (e.g.,
+floats), two arguments with the same contents might or might not be
+the same object, and @code{eq} returns @code{t} or @code{nil}
+depending on whether the Lisp interpreter created one object or two.
@example
@group
@@ -2095,6 +2099,12 @@ Equality Predicates
@result{} t
@end group
+@group
+(eq 3.0 3.0)
+ @result{} t @r{or} nil
+;; @r{The result is implementation-dependent.}
+@end group
+
@group
(eq "asdf" "asdf")
@result{} nil
--
2.14.3
next prev parent reply other threads:[~2018-04-02 19:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 23:04 Floating-point constant folding in Emacs byte compiler Paul Eggert
2018-03-23 1:26 ` Stefan Monnier
2018-03-23 5:22 ` Paul Eggert
2018-03-23 8:24 ` Eli Zaretskii
2018-03-23 20:00 ` Paul Eggert
2018-03-23 8:15 ` Eli Zaretskii
2018-03-23 20:52 ` Pip Cet
2018-03-24 6:25 ` Eli Zaretskii
2018-03-26 9:39 ` Robert Pluim
2018-03-26 15:13 ` Eli Zaretskii
2018-03-26 15:57 ` Robert Pluim
2018-03-26 16:02 ` Eli Zaretskii
2018-03-26 18:23 ` Pip Cet
2018-03-26 18:29 ` Eli Zaretskii
2018-03-27 0:28 ` Paul Eggert
2018-03-27 23:28 ` Paul Eggert
2018-03-30 16:26 ` Pip Cet
2018-03-30 16:31 ` Noam Postavsky
2018-03-30 16:39 ` Paul Eggert
2018-04-02 10:56 ` Pip Cet
2018-04-02 11:22 ` Eli Zaretskii
2018-04-02 11:42 ` Pip Cet
2018-04-02 12:50 ` Eli Zaretskii
2018-04-02 14:50 ` Stefan Monnier
2018-04-02 15:02 ` Pip Cet
2018-04-02 12:57 ` Noam Postavsky
2018-04-02 13:30 ` Eli Zaretskii
2018-04-02 14:48 ` Stefan Monnier
2018-04-02 19:20 ` Paul Eggert [this message]
2018-04-02 19:39 ` Pip Cet
2018-04-02 19:58 ` Eli Zaretskii
2018-04-02 20:55 ` Pip Cet
[not found] ` <<83y3i568i0.fsf@gnu.org>
2018-04-02 13:37 ` Drew Adams
2018-04-02 14:05 ` Eli Zaretskii
2018-04-02 14:54 ` Pip Cet
2018-04-02 15:02 ` Drew Adams
2018-03-26 17:52 ` Stefan Monnier
2018-03-26 18:30 ` Eli Zaretskii
2018-03-27 0:08 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=058336f6-1b68-69c5-27ee-13edeb86f636@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).