From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/osm 05ac461360: Bail out earlier if dependencies are missing Date: Wed, 11 May 2022 00:07:31 +0200 Message-ID: <04e511b4-f988-401b-92a4-32fce1b5e115@daniel-mendler.de> References: <165221267003.11226.2207874159602256273@vcs2.savannah.gnu.org> <20220510195750.558C1C01683@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22108"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 11 00:08:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noY2G-0005Z2-28 for ged-emacs-devel@m.gmane-mx.org; Wed, 11 May 2022 00:08:52 +0200 Original-Received: from localhost ([::1]:34142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noY2E-0007bX-Ka for ged-emacs-devel@m.gmane-mx.org; Tue, 10 May 2022 18:08:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noY1N-0006Dl-Su for emacs-devel@gnu.org; Tue, 10 May 2022 18:07:57 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:37275 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noY1L-0000xH-3c for emacs-devel@gnu.org; Tue, 10 May 2022 18:07:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ATNvxFQYGv285kCPUhNXP1q1CLHeN3cvV7ez5YO8Xv8=; b=Pncy7Vbdm1UkZaD57/0aOdw5o5 6wx/TqjpDF7FuZUTkx1OLcXg8xR+hoJ/zc0dQ12AeOE0ldVVXxFe8HPiZNmNzIXGE4lsRsE+sdmEK jMvIVtcxPQZrLAFsgkWDzncAL9qBZwEkdy/AQTO3POJEO3MBL+CUSTciT3WonOpbQlWE=; Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289605 Archived-At: On 5/10/22 23:00, Stefan Monnier wrote: > Better not signal such errors when loading the file, since the file might > be loaded for all kinds of reasons beside running its code. In some of > those cases it can get loaded in an Emacs batch session. I agree that the global check is a code smell. In this case I don't expect batch usage since we are talking about a mouse driven map display. The alternative would be to replicate the check in all the entry points to the package, the osm-mode, the autoloaded osm-* commands, which would require more code. Daniel