From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [External] : Improvement proposals for `completing-read' Date: Fri, 9 Apr 2021 19:41:27 +0200 Message-ID: <04978320-51b7-28e7-d8f0-51ed681dee91@daniel-mendler.de> References: <3470841e-d0ef-69d2-aa58-67fd0fd57645@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29638"; mail-complaints-to="usenet@ciao.gmane.io" To: "emacs-devel@gnu.org" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 09 19:43:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUvAD-0007dz-9r for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Apr 2021 19:43:25 +0200 Original-Received: from localhost ([::1]:49534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUvAC-0002kX-BU for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Apr 2021 13:43:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUv8h-0001VX-5w for emacs-devel@gnu.org; Fri, 09 Apr 2021 13:41:51 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:43229 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUv8e-0002B4-Hv for emacs-devel@gnu.org; Fri, 09 Apr 2021 13:41:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yYCDeFCuG1JsZU01mT7ca1eBd7kjpR6za39Nr/83Nl8=; b=MpJNidRSs4D2PE1anJIzq6WNyD aITDXM19+FLCq36aZpEVG4ODopOEHxX+iehBZ99CLjXeUU/xAXm+sInhsnLzVN/LaAQWTleePuQd4 KFvum0pGfHbSX5vwghJFdJEudmunv/FS1gDh6Y7xRHJSouMMXv2fX6ft3QEDEMKqHrqA=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267732 Archived-At: On 4/9/21 7:22 PM, Drew Adams wrote: > None of what you wrote has to do with what Daniel > posited: use of `completing-read' with a history > list providing the completion candidates. (That's > at least what I understood him to mean.) E.g., > > (completing-read "Choose from file-name input history: " > file-name-history) > > (completing-read "Choose from regexp input history: " > regexp-history) > > (completing-read "Choose from input history: " > minibuffer-history) > > I think Daniel was suggesting that it makes sense > in all such cases to use `t' for the HIST arg. E.g.: > > (completing-read "Choose from input history: " > minibuffer-history nil nil nil t) > > I'm guessing his point would be that without `t' > traversing the history (e.g. with `M-p' or `M-r') > would be a redundant way to get to a completion > candidate, which it would be. Yes, you understood me correctly. Note also that if you specify a variable, the value of the history variable is modified. When browsing a history the desire to avoid modifying the history itself is not unreasonable. This means that in any case you would want to use a different history variable than the one you are accessing, the history of your history browsing. > And if the REQUIRE arg is nil then it can even be > useful to use a _different_ history for the HISTORY > arg from that used for the COLLECTION arg. Sure you can do that. You can have a history of your history browsing and then a history of your history of your history browsing. All I am proposing is the removal of the unnecessary restriction of disallowing `t` for the HIST argument of `completing-read`. If you look at `completing-read-default`, it calls `read-from-minibuffer` directly, which accepts this. If you use a different completion system, the situation may be different. Daniel Mendler