From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= <cpitclaudel@gmail.com>
Newsgroups: gmane.emacs.devel
Subject: Re: html, css, and js modes working together
Date: Wed, 1 Feb 2017 02:29:25 -0500
Message-ID: <0413f338-7361-5c8d-510c-bb3d9e5c70d7@gmail.com>
References: <87o9ynarz3.fsf@tromey.com>
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Trace: blaine.gmane.org 1485934201 14288 195.159.176.226 (1 Feb 2017 07:30:01 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Wed, 1 Feb 2017 07:30:01 +0000 (UTC)
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
	Thunderbird/45.7.0
To: Tom Tromey <tom@tromey.com>, Emacs discussions <emacs-devel@gnu.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 01 08:29:56 2017
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1cYpMa-0003ar-CC
	for ged-emacs-devel@m.gmane.org; Wed, 01 Feb 2017 08:29:56 +0100
Original-Received: from localhost ([::1]:43085 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1cYpMf-0004jl-SS
	for ged-emacs-devel@m.gmane.org; Wed, 01 Feb 2017 02:30:01 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cpitclaudel@gmail.com>) id 1cYpMB-0004Xh-JM
	for emacs-devel@gnu.org; Wed, 01 Feb 2017 02:29:32 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cpitclaudel@gmail.com>) id 1cYpM7-0006Iv-KF
	for emacs-devel@gnu.org; Wed, 01 Feb 2017 02:29:31 -0500
Original-Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:33924)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <cpitclaudel@gmail.com>)
	id 1cYpM7-0006Ir-Fi
	for emacs-devel@gnu.org; Wed, 01 Feb 2017 02:29:27 -0500
Original-Received: by mail-qt0-x242.google.com with SMTP id w20so29529347qtb.1
	for <emacs-devel@gnu.org>; Tue, 31 Jan 2017 23:29:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=subject:to:references:from:message-id:date:user-agent:mime-version
	:in-reply-to:content-transfer-encoding;
	bh=R/kCY43H/f+cTH4bhQjnrBOxwKL7sV92qUXQUCuu7zo=;
	b=HmTI7Tbo8GLxr0MHHQD2Xu5TyuLi86ftTx/ogxrGhSkA4cDOcgcs2vqKzSSULuBHWM
	/BLg6inH5x3aIk+aiYyt1UGLykrFoodQccoI5hvO5RQUSB23VsTV0IYKVb5/Ns11u3hQ
	FaWkU+39cU7OHIgk5y7Gz0zmtMDkRS+hkV71cEwX/P6MeUS7nCv/jCAwiTU/lp2GXMy0
	rS7TwP4hdB119t2vX5H6W/EF980Jl6x9uuqB6fD45+++FYRkFWkk+krapJjUn1rKpCO0
	JuLhkkdrEEfvch9XmLvDqESH7ztP24T/p2B5O+SaSwJ7MJei/nvrgMqpKV8Z+K1zNGec
	2GIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:subject:to:references:from:message-id:date
	:user-agent:mime-version:in-reply-to:content-transfer-encoding;
	bh=R/kCY43H/f+cTH4bhQjnrBOxwKL7sV92qUXQUCuu7zo=;
	b=qduI+HycNZpNxrDhjlf2XZ5AEW1oyek5PKTIjc0eN8BPTpE+/T/VeWOrBBiysFi6MY
	ADNyHvv1ulW6nmxoxOUWXm7+QQuZYgrrOmvMtlTQqYpOkYNX7RyvXSEUksWUYsvOuG4J
	+duimK5NmIplydcq9IrtaTpiZl6HEl2XHNgMZCjpTrgo5w0yZgpN0tr4L4EXNQ2hgu6P
	phTGCi0LRPBgA7WR8B8TJvGEeRXNhH5A8wgDCk2WzqnoUP4VuojJNa8M7CKTEKDqZU7c
	bPjB2P8q9sM+tDI0gLhagEzBhTLOadh6EGGdsoU0xclgy7rx9XSOHWXfbsU+zruh+7iS
	yC3Q==
X-Gm-Message-State: AIkVDXIdiNeeTWP4S5XC0DY9t9AsEMKzB8ejNAX6yl8c2ETwsEuQZCDTHBj3CN3m2OPccA==
X-Received: by 10.200.52.27 with SMTP id u27mr1435772qtb.26.1485934166735;
	Tue, 31 Jan 2017 23:29:26 -0800 (PST)
Original-Received: from [18.189.98.234] (dhcp-18-189-98-234.dyn.MIT.EDU.
	[18.189.98.234]) by smtp.gmail.com with ESMTPSA id
	o14sm17811449qtc.46.2017.01.31.23.29.26
	(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Tue, 31 Jan 2017 23:29:26 -0800 (PST)
In-Reply-To: <87o9ynarz3.fsf@tromey.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2607:f8b0:400d:c0d::242
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:211829
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/211829>

On 2017-01-31 15:34, Tom Tromey wrote:
> This patch changes the html, css, and js modes to work together a bit.
> With this, the contents of a <style> element are syntax-highlighted and
> indented according to css-mode rules, and the contents of a <script>
> element are syntax-highlighted and indented according to js-mode rules.
> I'd appreciate comments on this approach.

Hi Tom,

I haven't tried the patch, but I can offer a few comments:

I'm a bit wary of rules like the following:

    "<script.*?>\\(\\(\n\\|.\\)*?\\)</script>"

Won't this pick up <script> tags in comments?  And won't matching large <script> tags going to be costly?  An alternative would be to find the opening tag, check the context that it appears in, and if it is indeed a proper <script> tag search forward to find the closing tag.

I also don't think adding #'syntax-propertize-multiline to 'syntax-propertize-extend-region-functions is enough to ensure proper syntax-propertization (this could miss large scripts — larger than a screenful, couldn't it?).

Finally: how much of a performance impact does this have? Recomputing syntax properties for entire <script> and <style> tags for every edit sounds a bit costly.

Cheers,
Clément.