From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Sat, 08 May 2021 22:27:13 +1000 Organization: By Dasein Message-ID: <03FB7137-A02D-4B94-AF1F-8B7E84DEF5DB@bydasein.com> References: <9cdf9d6dc55ccd4894d758d3237b0be2@purelymail.com> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3684"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Purely Mail via Roundcube/1.4.10 Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 08 14:28:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfM4i-0000q1-Kh for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 14:28:53 +0200 Original-Received: from localhost ([::1]:33490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfM4h-00045E-NT for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 08:28:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfM3V-0003Fb-1Y for emacs-devel@gnu.org; Sat, 08 May 2021 08:27:41 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:53326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfM3T-0008Iu-3t for emacs-devel@gnu.org; Sat, 08 May 2021 08:27:36 -0400 DKIM-Signature: a=rsa-sha256; b=GjqPkOGcS+zo5g/6WYaGmt0hjI3AKz+suyjamINTdXhU+LZHP5l28L6PWo2kMBXE4EYTGwCvPjM1IGlSBCyqH4O9nBWBvhYDS22aWQjFo3W21v82PI12hvmwLMlmyHC3uWCxm+6qOfIokpKsTdw13lNlNlEz3HnESjsX7PgZ8MRrhBYvHt7Fl6mAVAMmMuR1vWXCjaQQnMlypazNQergQqPuow73hLcNykBH1xca0soGmYbtNfc8W9p3y6k24uR3kuq/4iUq+QlRufBxl6nExC2NEy7OEx1hKldJ3Nnx4W05y2tXO4fnV8HXOIVJ3LiLuUzX1Yzb0R5Pp/lg0eRn5g==; s=purelymail2; d=bydasein.com; v=1; bh=ujZDZmxpO3NBFkiXzsckxTw9GjMcFMLc8jANfMle5DY=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=Bt6MOgX7VT8OUzpa67TyvzUxMxptfcrjuVGD4FXkiWKLU4x5PcTHKDZDL5YUIpXp9KZwoTbDUa5N5i0yJm+wLkHXGxgE65y0UFuyNhpG30CbHOrwi07G4KIEQzEdfDGzA8qXi2tmWZ2z7pE3Eb1ZHAL4Q25wpt91PwphDfimIZCrspjfhn+ofxogZdW+QQoYoLrn3m4E9pZGYCwvPBOUIAbhN+ANc6Dn8ymYGiR2EQl3qvvTeU4oy1ov1CE3vxzp+eRrgl970a4FjpesogmXtrZWewA78DV/9cIH3fVr1eKGMoWOaUxoKrVEdSo3kyrKQrxu1r/gwHsDHot2byeskw==; s=purelymail2; d=purelymail.com; v=1; bh=ujZDZmxpO3NBFkiXzsckxTw9GjMcFMLc8jANfMle5DY=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by ip-172-30-0-124.ec2.internal (JAMES SMTP Server ) with ESMTPA ID -696983826; Sat, 08 May 2021 12:27:13 +0000 (UTC) In-Reply-To: X-Sender: pwr@bydasein.com Received-SPF: pass client-ip=34.202.193.197; envelope-from=pwr@bydasein.com; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269042 Archived-At: > On 8 May 2021, at 9:21 pm, Alan Third wrote: >> src/nsterm.m: use NSWindowTabbingModeAutomatic to respect user choice. >> Tabbed window managers are now widely available for free systems. > > For the record the tabbing being enabled here is not Emacs's own > tabbing, it's a macOS method of combining multiple OS windows into > one. Emacs's tabbing has still to be implemented on the NS port (I've > no interest as I think tabbed windows are an abomination that should > be burnt on sight, but would happily let someone else implement it). I think all the more reason not to hobble the macOS window manager! But yes it should be noted that tabs here are in the context of window management (i.e. Emacs frames) not tab-bar-mode. A Linux counterpart would be https://tools.suckless.org/tabbed/ > Paul, is this still the absolute disaster it was when it first > appeared where some random Emacs frames would get combined but not > others, not to mention the crashes? Also there was no "user choice" as > I recall, it just happened without any warning or input from the user, > at random. > > Is it actually stable and usable now? I've been building Emacs with this change applied for several years now across a few different macOS versions and I've never experienced a crash or unexpected behaviour. But it depends on what you might be doing that I'm not; can you provide a step-by-step? The user choice I refer to resides in the odd place of System Preferences > Dock > Prefer tabs when opening documents: [Always | In Full Screen Only | Manually]. The behaviour I've experienced with each of these is: - Always: invoking `make-new-frame' will always create a frame in a new tab - In Full Screen Only: invoking `make-new-frame' will create a frame in a new tab only when `(frame-parameter nil 'fullscreen)' is non-nil - Manually: `make-new-frame' will never create new tabs (Off topic but it would be nice if there were some mention in the docs that tab-bar-mode does not function at all on macOS rather than silently failing.)