From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master updated (5af5ed6c62 -> f07505d1ec) Date: Wed, 7 Sep 2022 14:03:41 -0700 Message-ID: <038f151d-19db-b4ea-3172-76f34014c147@gmail.com> References: <166233264971.21612.17042094685015365861@vcs2.savannah.gnu.org> <87fsh665fj.fsf@gnus.org> <87r10ox2xl.fsf@gnus.org> <87wnagp8gf.fsf@gnus.org> <563857da-1467-4181-1c69-dcf4c968314b@gmail.com> <874jxjpfua.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------43569FEB8DF2C6125A5DD25E" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33554"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 07 23:04:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oW2EB-0008St-Oc for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 23:04:55 +0200 Original-Received: from localhost ([::1]:48806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oW2EA-0002oN-MY for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 17:04:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW2D4-00025w-Ao for emacs-devel@gnu.org; Wed, 07 Sep 2022 17:03:46 -0400 Original-Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:52031) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oW2D2-0002YK-Mm for emacs-devel@gnu.org; Wed, 07 Sep 2022 17:03:45 -0400 Original-Received: by mail-pj1-x1034.google.com with SMTP id m3so5131496pjo.1 for ; Wed, 07 Sep 2022 14:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:from:to:cc:subject:date; bh=35+ZiHaFBJYYz2AX1ZC3NYh85LxkXZhCY893Hs2l8e4=; b=FcuaKkjNarrnvYEDMh0ytFjHcmMtQKbbxzE9vt103Hj7EnmZaB2qNtW5U3TRC6QV+u jfuFZhWb/3tpV4tz0LpoJzDsTT+wc4ypwqE+0NhxoP6T4AqrSNR5QcEtq7SU2QW6BMPc e2oQ6QNCM42pTsXl4YHMW8ev4Mr17Rd10h69qLz10OIC+YtaKHIQImu+0eHb4N0WdulM rNpKfKjHE9LiIAs6JPZhGJhjl5W3gsSLUaBakWf4treT4XK20Rx2UEQxkjFLH2QlveCh d5R3xrDTDzt4M3qc5W8+pDhaI5pPA3MROCZELJCcheC2KaXp2v0qfooWur4VvPwpybRt VK8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:x-gm-message-state:from:to:cc:subject:date; bh=35+ZiHaFBJYYz2AX1ZC3NYh85LxkXZhCY893Hs2l8e4=; b=myNvqrOqlQcJCmAB0YbwYS+c/p2Fh13XyQIKS99N3Jj+1QSaEB6wkordRha5Dl02Yp vNiaru6rzRdLc3MP0FNIeVr67dvOLA8zY3LbXB73aT1Vhr+bs+CwxVUxLTPQXsxM4dIL yL24Pur8HK6crCe+1gXBsa5GvXLSRJrT7t6VXNdsUe/F0ZE5urWWjjCuFjiutBZM3OUP IIn5dC/UiFA3m9ZZ51/kBz0pJYvidyvQa/Mx3VG1oDEF/D6DAlEYREZvFnpFpSDDQXon Bg63NjnlQGQfiMSLkUK2tUpyS5yEfE3A09N25IBZ2ELVlBgFI+myOI+pSebpHqCmLbBh 6akw== X-Gm-Message-State: ACgBeo2p3zRzlC+BrdPXmnWSWa1CvM+Oy99hhBlF4md7E7nfx4DMLPBN 886Y3wHhibhvM/PP7CzIs9OrBrbOcqg= X-Google-Smtp-Source: AA6agR4PjHmPnmMHGL5RhR/+2+Q1MoJnhrTMAiV+4NvGK2dv9a8/AkGjaLhZnPYfseuXigUeSwfE1Q== X-Received: by 2002:a17:90b:1b0c:b0:202:3511:f1ed with SMTP id nu12-20020a17090b1b0c00b002023511f1edmr432222pjb.118.1662584623343; Wed, 07 Sep 2022 14:03:43 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u15-20020a1709026e0f00b00176d0b44be2sm4813700plk.47.2022.09.07.14.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Sep 2022 14:03:41 -0700 (PDT) In-Reply-To: <874jxjpfua.fsf@gnus.org> Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294882 Archived-At: This is a multi-part message in MIME format. --------------43569FEB8DF2C6125A5DD25E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 9/7/2022 4:46 AM, Lars Ingebrigtsen wrote: > In the last run on EMBA, that test didn't fail, but this one did: > > Test esh-proc-test/sigpipe-exits-process condition: > (ert-test-failed > ((should > (eq > (process-list) > nil)) > :form > (eq > (#) > nil) > :value nil)) > FAILED 16/16 esh-proc-test/sigpipe-exits-process (1.013610 sec) at lisp/eshell/esh-proc-tests.el:122 > Ran 16 tests, 14 results as expected, 1 unexpected, 1 skipped (2022-09-07 10:27:03+0000, 2.594968 sec) > 1 unexpected results: > FAILED esh-proc-test/sigpipe-exits-process ((should (eq > (process-list) nil)) :form (eq (#) nil) :value > nil) Luckily, that's an easy one to fix. See attached. The changes for bug#21605 resulted in that test spawning an extra pipe process to monitor stderr, which confused the test. For simplicity, I just tweaked the pipeline in that test to avoid spawning the pipe process. --------------43569FEB8DF2C6125A5DD25E Content-Type: text/plain; charset=UTF-8; name="0001-Fix-a-race-condition-in-an-Eshell-test.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-a-race-condition-in-an-Eshell-test.patch" RnJvbSBjNmJiMDljNGFjMjJmZmE3NmYyNDhjY2NhODI4NTM5N2NjNDZmMTJlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgNyBTZXAgMjAyMiAxMzo1ODozMSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBhIHJhY2UgY29uZGl0aW9uIGluIGFuIEVzaGVsbCB0ZXN0CgoqIHRlc3QvbGlz cC9lc2hlbGwvZXNoLXByb2MtdGVzdHMuZWwKKGVzaC1wcm9jLXRlc3Qvc2lncGlwZS1leGl0 cy1wcm9jZXNzKTogVXNlICJ8JiIgd2hlbiBjcmVhdGluZyB0aGUKcGlwZWxpbmUgdG8gcHJl dmVudCBhbiBleHRyYSBwaXBlIHByb2Nlc3MgZnJvbSBiZWluZyBzdGFydGVkLgotLS0KIHRl c3QvbGlzcC9lc2hlbGwvZXNoLXByb2MtdGVzdHMuZWwgfCA2ICsrKystLQogMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90 ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsIGIvdGVzdC9saXNwL2VzaGVsbC9l c2gtcHJvYy10ZXN0cy5lbAppbmRleCA1MmEwZDFlZWViLi5hYmUzNjNiZWUwIDEwMDY0NAot LS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlz cC9lc2hlbGwvZXNoLXByb2MtdGVzdHMuZWwKQEAgLTEyOCw4ICsxMjgsMTAgQEAgZXNoLXBy b2MtdGVzdC9zaWdwaXBlLWV4aXRzLXByb2Nlc3MKICAgIChlc2hlbGwtbWF0Y2gtY29tbWFu ZC1vdXRwdXQKICAgICA7OyBUaGUgZmlyc3QgY29tbWFuZCBpcyBsaWtlIGB5ZXMnIGJ1dCBz bG93ZXIuICBUaGlzIGlzIHRvIHByZXZlbnQKICAgICA7OyBpdCBmcm9tIHRheGluZyBFbWFj cydzIHByb2Nlc3MgZmlsdGVyIHRvbyBtdWNoIGFuZCBjYXVzaW5nIGEKLSAgICA7OyBoYW5n LgotICAgIChjb25jYXQgInNoIC1jICd3aGlsZSB0cnVlOyBkbyBlY2hvIHk7IHNsZWVwIDE7 IGRvbmUnIHwgIgorICAgIDs7IGhhbmcuICBOb3RlIHRoYXQgd2UgdXNlICJ8JiIgdG8gY29u bmVjdCB0aGUgcHJvY2Vzc2VzIHNvIHRoYXQKKyAgICA7OyBFbWFjcyBkb2Vzbid0IGNyZWF0 ZSBhbiBleHRyYSBwaXBlIHByb2Nlc3MgZm9yIHRoZSBmaXJzdCAic2giCisgICAgOzsgaW52 b2NhdGlvbi4KKyAgICAoY29uY2F0ICJzaCAtYyAnd2hpbGUgdHJ1ZTsgZG8gZWNobyB5OyBz bGVlcCAxOyBkb25lJyB8JiAiCiAgICAgICAgICAgICAic2ggLWMgJ3JlYWQgTkFNRTsgZWNo byAke05BTUV9JyIpCiAgICAgInlcbiIpCiAgICAoZXNoZWxsLXdhaXQtZm9yLXN1YnByb2Nl c3MgdCkKLS0gCjIuMjUuMQoK --------------43569FEB8DF2C6125A5DD25E--