From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: [patch] add "underwave" face attribute Date: Fri, 27 Jan 2012 09:08:00 -0800 Message-ID: <037B3467A9FE4EC9B681DF3B1171A539@us.oracle.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1327684105 6924 80.91.229.12 (27 Jan 2012 17:08:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 27 Jan 2012 17:08:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: "'Stefan Monnier'" , "=?iso-8859-1?Q?'Aur=E9lien_Aptel'?=" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 27 18:08:18 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RqpHd-0006y5-G8 for ged-emacs-devel@m.gmane.org; Fri, 27 Jan 2012 18:08:17 +0100 Original-Received: from localhost ([::1]:58939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqpHc-0005YX-Q1 for ged-emacs-devel@m.gmane.org; Fri, 27 Jan 2012 12:08:16 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:42162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqpHV-0005YP-VT for emacs-devel@gnu.org; Fri, 27 Jan 2012 12:08:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqpHV-0003IB-1g for emacs-devel@gnu.org; Fri, 27 Jan 2012 12:08:09 -0500 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:36559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqpHU-0003Hu-SY for emacs-devel@gnu.org; Fri, 27 Jan 2012 12:08:09 -0500 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id q0RH85EE029726 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 Jan 2012 17:08:06 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q0RH84YR017703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 27 Jan 2012 17:08:05 GMT Original-Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q0RH84Hd018539; Fri, 27 Jan 2012 11:08:04 -0600 Original-Received: from dradamslap1 (/10.159.35.238) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 27 Jan 2012 09:08:04 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AczdC3ocv2xmJP5oTyqvAiUsPw206QACo79A X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090201.4F22D9F6.0134,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 148.87.113.117 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147987 Archived-At: > The feature sounds good, I'll let others judge the implementation > quality, but I have one issue with the "user interface": do we really > want to let faces specify underline and underwave separately? No. > Maybe another approach is to include it as an additional value > for underline (which can currently be either a boolean or a > color name, so we'd have to extend the set of value so as to be > able to specify shape and color separately). +1 (And please implement it on other platforms as well.)