From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c Date: Sat, 19 Jan 2019 13:33:39 -0800 Message-ID: <034912a4e687ae39bfc17b45ec6a9ef7.squirrel@dancol.org> References: <20190119182259.26893.32117@vcs0.savannah.gnu.org> <20190119182301.0DE562043D@vcs0.savannah.gnu.org> NNTP-Posting-Host: ciao.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ciao.gmane.org 1547933641 74311 195.159.176.228 (19 Jan 2019 21:34:01 GMT) X-Complaints-To: usenet@ciao.gmane.org NNTP-Posting-Date: Sat, 19 Jan 2019 21:34:01 +0000 (UTC) User-Agent: SquirrelMail/1.4.23 [SVN] To: emacs-devel@gnu.org, "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 19 22:33:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1gkyFZ-000JGw-Oe for ged-emacs-devel@m.gmane.org; Sat, 19 Jan 2019 22:33:58 +0100 Original-Received: from localhost ([127.0.0.1]:60073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkyFg-0004Y6-DG for ged-emacs-devel@m.gmane.org; Sat, 19 Jan 2019 16:34:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkyFX-0004Y0-9v for emacs-devel@gnu.org; Sat, 19 Jan 2019 16:33:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkyFV-0002QU-CP for emacs-devel@gnu.org; Sat, 19 Jan 2019 16:33:55 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:49000) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkyFR-0002CI-HK; Sat, 19 Jan 2019 16:33:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=2r3ITpnNKhcp2Z9f9aKJp8Lpc8xV9CrSRomNGiFqr5k=; b=iGvF3Ac+cOltZjsI4N+zQZAff09pJUnqCblqOPxHMAxe6wI1Bxok6xuzbsWUZ8xcASVtNnB0JWT230/bdT1OpcCBbLf0bNGnhIZmIaJyfh2e6GpV8DwZur4HYIAIZJuSEss6+l2Tse22nc92fpLr6Uc+wfTP5yO+FU9h5YEFOyudn1whtaJN7SpLFXSr0vqnwgXoauaB/SRF0W6Eztcunm5kjNSTld1/VmxnLslKqX0ZB//9psaIvf53xWD3Zrj+9LzPLQH/S0aIFZ8d/NDp+j0VEdl7N0uNUMtMIQH2WWrLTsRUm+KzT/GME21e2H1Oe1GVFaIBh4OxPKb06KjhRw==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkyFH-000868-CB; Sat, 19 Jan 2019 13:33:39 -0800 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Sat, 19 Jan 2019 13:33:39 -0800 In-Reply-To: <20190119182301.0DE562043D@vcs0.savannah.gnu.org> X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232499 Archived-At: > branch: master > commit 8e2b2a2b179c3ed170ad9de32a320e788c6a3a5e > Author: Eli Zaretskii > Commit: Eli Zaretskii > > Minor cleanup in pdumper.c > > * src/pdumper (subtract_timespec): Function removed. > (pdumper_load): Use timespec_sub instead of subtract_timespec. > --- > src/pdumper.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/src/pdumper.c b/src/pdumper.c > index b51a379..1c49167 100644 > --- a/src/pdumper.c > +++ b/src/pdumper.c > @@ -5388,15 +5388,6 @@ enum dump_section > NUMBER_DUMP_SECTIONS, > }; > > -/* Subtract two timespecs, yielding a difference in milliseconds. */ > -static double > -subtract_timespec (struct timespec minuend, struct timespec subtrahend) Cmon, don't you think we should do better than open-code timespec operations?