From: Glenn Morris <rgm@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Emacs developers <emacs-devel@gnu.org>,
Noam Postavsky <npostavs@users.sourceforge.net>
Subject: Re: master 583995c: GnuTLS HMAC and symmetric cipher support
Date: Mon, 17 Jul 2017 18:14:42 -0400 [thread overview]
Message-ID: <02lgnm1zjh.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <3f44fabe-80b7-8a01-2b64-0a33b2a311b3@cs.ucla.edu> (Paul Eggert's message of "Mon, 17 Jul 2017 14:58:44 -0700")
Paul Eggert wrote:
> Glenn Morris wrote:
>
>> Seems a bit like a happy accident?):
>
> It's not an accident, as every valid cipher etc. has a name.
>
>> 1. Fgnutls_ciphers. Can intern NULL and crash.
>> const gnutls_cipher_algorithm_t *gciphers = gnutls_cipher_list ();
>> for (ptrdiff_t pos = 0; gciphers[pos] != GNUTLS_CIPHER_NULL; pos++)
>> {
>> gnutls_cipher_algorithm_t gca = gciphers[pos];
>> Lisp_Object cipher_symbol = intern (gnutls_cipher_get_name (gca));
>> ...
>> }
>
> It's OK, as every cipher other than GNUTLS_CIPHER_NULL has a non-NULL name.
But it isn't OK. That's what this thread is about.
GNUTLS_CIPHER_UNKNOWN apparently has a NULL name.
next prev parent reply other threads:[~2017-07-17 22:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170714150706.13106.18905@vcs0.savannah.gnu.org>
[not found] ` <20170714150707.5E9B322DF8@vcs0.savannah.gnu.org>
2017-07-17 0:05 ` master 583995c: GnuTLS HMAC and symmetric cipher support Glenn Morris
2017-07-17 14:18 ` Ted Zlatanov
2017-07-17 14:30 ` Michael Albinus
2017-07-17 14:50 ` Ted Zlatanov
2017-07-17 18:22 ` Michael Albinus
2017-07-17 17:12 ` Glenn Morris
2017-07-17 17:19 ` Noam Postavsky
2017-07-17 18:20 ` Glenn Morris
2017-07-17 18:45 ` Noam Postavsky
2017-07-17 19:27 ` Glenn Morris
2017-07-17 19:44 ` Paul Eggert
2017-07-17 21:37 ` Glenn Morris
2017-07-17 21:58 ` Paul Eggert
2017-07-17 22:14 ` Glenn Morris [this message]
2017-07-18 0:59 ` Paul Eggert
2017-07-18 2:33 ` Glenn Morris
2017-07-18 7:45 ` Paul Eggert
2017-07-18 18:44 ` Glenn Morris
2017-07-18 20:44 ` Paul Eggert
2017-07-18 21:02 ` Glenn Morris
2017-07-18 21:16 ` Paul Eggert
2017-07-18 21:29 ` Glenn Morris
2017-07-23 19:18 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02lgnm1zjh.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).