From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Why does make run git? Date: Wed, 2 Aug 2017 11:42:43 -0700 Organization: UCLA Computer Science Department Message-ID: <02f6233d-b0ef-5a8f-9089-f3fc3496df02@cs.ucla.edu> References: <83bmo00yw7.fsf@gnu.org> <6d947774-836a-7286-4214-ddc5f516577f@cs.ucla.edu> <83a83hzuqv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1501699414 25341 195.159.176.226 (2 Aug 2017 18:43:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Aug 2017 18:43:34 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 Cc: emacs-devel@gnu.org, rms@gnu.org, tino.calancha@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 02 20:43:30 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcyc6-0005yL-SX for ged-emacs-devel@m.gmane.org; Wed, 02 Aug 2017 20:43:22 +0200 Original-Received: from localhost ([::1]:49770 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcycC-00040d-UP for ged-emacs-devel@m.gmane.org; Wed, 02 Aug 2017 14:43:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcyba-00040L-FH for emacs-devel@gnu.org; Wed, 02 Aug 2017 14:42:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcybZ-0004y4-He for emacs-devel@gnu.org; Wed, 02 Aug 2017 14:42:50 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44210) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcybW-0004qg-5Q; Wed, 02 Aug 2017 14:42:46 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 450861606F9; Wed, 2 Aug 2017 11:42:44 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qemJ1_KKkbe4; Wed, 2 Aug 2017 11:42:43 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8822C16073B; Wed, 2 Aug 2017 11:42:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ndj5kv5GQKMV; Wed, 2 Aug 2017 11:42:43 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6BAC31606F9; Wed, 2 Aug 2017 11:42:43 -0700 (PDT) In-Reply-To: <83a83hzuqv.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217250 Archived-At: On 08/02/2017 11:31 AM, Eli Zaretskii wrote: >> To help improve the situation I propose the attached patch, which >> reverts the default ./autogen.sh behavior to be './autogen.sh all', the >> way it used to be (briefly). Developers who want autogen.sh to leave >> their Git settings alone can continue to use './autogen.sh autoconf'. > AFAIU, doing that will silently force the installation of the > Git-related stuff when I run just "make", and Make decides it needs to > invoke autogen.sh, because the fact that I originally used the > non-default argument isn't recorded anywhere, and thus cannot be > replayed. Right? No, if you run Make from a freshly-checked-out directory, Make calls "./autogen.sh all", which sets up Git. The proposed patch doesn't affect this. And if you run "./autogen.sh autoconf" and then run Make, Make won't set up Git. The proposed patch doesn't affect this either. The only thing that changes is what happens if you run plain "./autogen.sh".