unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Sean Whitton <spwhitton@spwhitton.name>, emacs-devel@gnu.org
Subject: Re: Eshell's external pipe module interferes with other argument parsing hooks
Date: Sun, 22 May 2022 21:34:30 -0700	[thread overview]
Message-ID: <02a7cd10-6b40-76a3-2baa-6085800b1aa9@gmail.com> (raw)
In-Reply-To: <0ac470ac-87e2-f3e9-7e23-28a6622ef082@gmail.com>

On 3/31/2022 4:11 PM, Jim Porter wrote:
> On 3/31/2022 2:56 PM, Sean Whitton wrote:
>> On Thu 31 Mar 2022 at 01:58PM -07, Jim Porter wrote:
>>> 1) Eshell's built-in pipelines are slow because they go through Emacs
>>> buffers.
[snip]
>>> For (1), Eshell could opportunistically use external pipelines without
>>> any special syntax.
> [snip]
>>
>> This could just be added to Eshell right now, right?  Definitely useful.
> 
> Unless there's a reason for Eshell's current behavior that I'm not aware 
> of, I can't think of any problems with doing this, so long as everything 
> is escaped properly.

On the subject of Eshell's built-in pipelines being slow, this might be 
of interest: 
<https://tdodge.consulting/blog/eshell/background-output-thread>. The 
author seems to have some interest in upstreaming the patch too[1].

I haven't had a chance to look at the patch in very much detail yet, but 
if this worked for all cases (apparently it's limited to PTY 
subprocesses for now, and I'm sure there are other cases where it would 
need to stay out of the way), it would be a huge improvement to 
"regular" Eshell pipes.

- Jim

[1] 
https://www.reddit.com/r/emacs/comments/usghki/comment/i93hkmv/?utm_source=reddit&utm_medium=web2x&context=3



      parent reply	other threads:[~2022-05-23  4:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <70677cd2-f741-16d1-b38f-c39b507cc95e@gmail.com>
     [not found] ` <871qyij7vx.fsf@melete.silentflame.com>
     [not found]   ` <fb254634-3ef6-99d8-c072-ad884f99ebe8@gmail.com>
2022-03-31 21:56     ` Eshell's external pipe module interferes with other argument parsing hooks Sean Whitton
2022-03-31 23:11       ` Jim Porter
2022-04-16 21:04         ` Sean Whitton
2022-05-23  4:34         ` Jim Porter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02a7cd10-6b40-76a3-2baa-6085800b1aa9@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=spwhitton@spwhitton.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).