unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
	Stefan Kangas <stefankangas@gmail.com>
Cc: Juanma Barranquero <lekktu@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>
Subject: RE: master 8f0f851: * lisp/autoarg.el: Use lexical binding.
Date: Mon, 20 Apr 2020 07:55:27 -0700 (PDT)	[thread overview]
Message-ID: <026ef78c-3c5e-4fd8-8161-0cc2cf5771c0@default> (raw)
In-Reply-To: <jwvwo6a1czk.fsf-monnier+emacs@gnu.org>

> > I don't think I understand the original warning though.

Same here.

> > This minimized code example gives me "Unused lexical
> > variable 'i'" when byte-compiled:
> >
> > (let (alist)
> >   (dotimes (i 10 alist) (push i alist)))
> 
> It's unused in the expression `alist`.

So?  (defun foo (a) (message "%s" a) 42) doesn't use
`a' in the value returned.  We don't warn about that,
do we?

> If you don't use `i` there, then you should do:
> (let (alist)
>   (dotimes (i 10) (push i alist))
>   alist)

Doesn't seem right to have such a distinction.  Is
this just an implementation artifact (essentially a
bug), or is there a good reason for the warning in
the first case (and not in the second)?

FWIW, all that Common Lisp says about its `dotimes'
in this regard is this:

"At the time result-form is processed, VAR is bound
to the number of times the body was executed."

Why should we warn, if the result form doesn't use
the variable?



  reply	other threads:[~2020-04-20 14:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200419004503.26161.91884@vcs0.savannah.gnu.org>
     [not found] ` <20200419004504.C65772049B@vcs0.savannah.gnu.org>
2020-04-19  6:18   ` master 8f0f851: * lisp/autoarg.el: Use lexical binding Juanma Barranquero
2020-04-20  5:10     ` Stefan Kangas
2020-04-20  5:34       ` Michael Heerdegen
2020-04-20 11:06         ` Noam Postavsky
2020-04-20 13:52       ` Stefan Monnier
2020-04-20 14:55         ` Drew Adams [this message]
2020-04-20 16:32           ` Stefan Monnier
2020-04-28  2:14             ` Michael Heerdegen
2020-04-28  2:59               ` Strange compiler warning in `dotimes' (was: master 8f0f851: * lisp/autoarg.el: Use lexical binding.) Michael Heerdegen
2020-04-28 15:32               ` master 8f0f851: * lisp/autoarg.el: Use lexical binding Drew Adams
2020-04-29  0:53                 ` Michael Heerdegen
2020-04-29  0:59                   ` Drew Adams
2020-04-29  1:13                     ` Michael Heerdegen
2020-04-29  1:23                       ` Drew Adams
2020-04-29  2:31                 ` Vladimir Sedach
2020-04-29  3:58                   ` Michael Heerdegen
2020-04-29  4:21                     ` Stefan Monnier
2020-04-29 18:33                     ` Vladimir Sedach
2020-04-29  4:02                   ` Stefan Monnier
2020-04-29 15:05                   ` Noam Postavsky
2020-04-30  2:26                   ` Richard Stallman
2020-05-16  3:21                     ` Michael Heerdegen
2020-04-29  3:53                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=026ef78c-3c5e-4fd8-8161-0cc2cf5771c0@default \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).