From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Tree-sitter and major mode inheritance Date: Wed, 16 Nov 2022 12:45:30 -0800 Message-ID: <0249C656-21C8-49F2-B979-A1894BF80637@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29814"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 16 21:46:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovPIV-0007cd-H2 for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Nov 2022 21:46:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovPHu-0003Gt-9Z; Wed, 16 Nov 2022 15:45:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovPHs-0003GX-M7 for emacs-devel@gnu.org; Wed, 16 Nov 2022 15:45:36 -0500 Original-Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovPHq-0004EE-QZ for emacs-devel@gnu.org; Wed, 16 Nov 2022 15:45:36 -0500 Original-Received: by mail-pg1-x52a.google.com with SMTP id f3so11444605pgc.2 for ; Wed, 16 Nov 2022 12:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=R/+VQdAVZfwkEvAivGh4TQjFn0DWaPxq7sS8U2z0krQ=; b=LgAwuYMkhImOT+iyMt2dAGi9DQkIrxtEt/nz2D0ukN+dHDnpw+Wf0BKJRFpdFFVeud 2VlY4kbYdKWqicxEBaaVoJa8c7qPMqXlbejFDBJHYWvfNk2c027Jw9JR2zU3GQ05k3Pz hPQGcM555Gqr8zQhHzK1KdbABecaOuI2iTrxvVkGyaUHGLFYGaSxGa5gPNrYJPhdPRos r0X0nYeKIkfivxftClnDggo1rHuvohpNN1tL64CFSMbQ4ygrG3kL3Y4cHjcBYrM7io6U djAihfChVcthFRpjHnOrfrEyQSaTKOmB/AWPljGb5gIwx3tLASLluPb0yKlTCjKm0iGa OFqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R/+VQdAVZfwkEvAivGh4TQjFn0DWaPxq7sS8U2z0krQ=; b=VuOV0Tcksy1eCk5KrEXFCPTLYIROLViOm6k8/7/z38GC5o6mUHKzE58Mcyy6VftUzR 9st+9PR7RSXs3T2olerMpk8SzUigVkIKIYR/tS3Vf0U0SQ5//BbYRdkP1Ru4Q4e9AyZT 8Nx9JUnx/MQ20qb0gVnjjLL58aO3jOZDDqks4aFtpLjUWmGkcFLuk17F04ThlAiJboxS r7IxmVRtoD2mq2JWiff36jkqW6gP2Z4Ek7sgxJP47a64VSauOXS4FrgOlMwgdiCr1aUO i2RLMCYlGPfKLBkIiiSNXmLQFLFmpLxG6G3cUxJbDBwGUzfRGviqgDYD4wXMBRvKZpQq 2BSQ== X-Gm-Message-State: ANoB5plxBdT05jjhFWhN+QywJS/vjGJJtdFLW+n3Pjvit05Uy4fgTXw+ gd6Ip4a4TDJCsjA6EbYWjErWlOuGn80= X-Google-Smtp-Source: AA0mqf6Hz97mmUSkmRPesGW6ZVVI2SdnRfpHracqio0ksIvyvK07MX4m+pQFfkQXq0UuEjjDPsFulA== X-Received: by 2002:a05:6a00:27a3:b0:563:771d:417f with SMTP id bd35-20020a056a0027a300b00563771d417fmr24755299pfb.45.1668631532013; Wed, 16 Nov 2022 12:45:32 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x13-20020a62860d000000b00562a526cd2esm11314513pfd.55.2022.11.16.12.45.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Nov 2022 12:45:31 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=casouri@gmail.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299988 Archived-At: So I=E2=80=99m trying to merge css-ts-mode with css-mode. Scss-mode = inherits css-mode, but if user enables tree-sitter for css-mode, = scss-mode will inherit all that tree-sitter setup, and lose all the = native css setup. Then if a user doesn=E2=80=99t want to enable = tree-sitter in scss-mode, too bad: scss-mode breaks. Essentially scss-mode needs to be able to control which parts of = css-mode=E2=80=99s setup it wants to inherit=E2=80=94native setup or = tree-sitter setup=E2=80=94regardless of whether css-mode enables = tree-sitter or not. I wonder if we can do something like this: css-mode | +---------+-----+-----------+ | | | css-native-mode css-ts-mode scss-mode | +----+------------+ | | scss-native-mode scss-ts-mode css-mode: a virtual mode, only sets up basic things that both native and = tree-sitter mode needs, like comment-start. css-native-mode: native setup css-ts-mode: tree-sitter setup scss-mode: a virtual mode, inherits css-mode scss-native-mode: native setup scss-ts-mode: tree-sitter setup And user could use major-mode-remap-alist to choose which mode they = want: (css-mode . css-ts-mode) for enabling tree-sitter (css-mode . css-native-mode) for not enabling tree-sitter This could also used for other modes, like c-mode: c-mode, c-native-mode = (cc-mode), c-ts-mode. Yuan=