From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert <eggert@cs.ucla.edu> Newsgroups: gmane.comp.sysutils.autoconf.patches,gmane.emacs.devel Subject: Re: [PATCH] Add quotes in AS_IF test for gid_t Date: Wed, 7 Feb 2024 13:22:47 -0800 Organization: UCLA Computer Science Department Message-ID: <02136282-9cb4-4c62-8f98-38803c51f618@cs.ucla.edu> References: <20240207033334.1489580-1-sam@gentoo.org> <4e0c6b19-07bc-fbc5-4e4c-df2b088db4cb@draconx.ca> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E5NEkfo07FfZXRqx6DlmdUz4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13027"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: autoconf-patches@gnu.org, Emacs development discussions <emacs-devel@gnu.org> To: Nick Bowler <nbowler@draconx.ca>, Sam James <sam@gentoo.org> Original-X-From: autoconf-patches-bounces+gnu-autoconf-patches=m.gmane-mx.org@gnu.org Wed Feb 07 22:23:28 2024 Return-path: <autoconf-patches-bounces+gnu-autoconf-patches=m.gmane-mx.org@gnu.org> Envelope-to: gnu-autoconf-patches@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <autoconf-patches-bounces+gnu-autoconf-patches=m.gmane-mx.org@gnu.org>) id 1rXpOC-0003BW-4A for gnu-autoconf-patches@m.gmane-mx.org; Wed, 07 Feb 2024 22:23:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <autoconf-patches-bounces@gnu.org>) id 1rXpNn-0000Yf-Px; Wed, 07 Feb 2024 16:23:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eggert@cs.ucla.edu>) id 1rXpNn-0000YQ-0Q; Wed, 07 Feb 2024 16:23:03 -0500 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eggert@cs.ucla.edu>) id 1rXpNk-0002JA-IP; Wed, 07 Feb 2024 16:23:02 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 3EAD93C011BC5; Wed, 7 Feb 2024 13:22:52 -0800 (PST) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id gxV59oAwaTmI; Wed, 7 Feb 2024 13:22:48 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id DE3293C011BD4; Wed, 7 Feb 2024 13:22:47 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu DE3293C011BD4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1707340967; bh=QL3PHQgbCGM5h4f1zVOsYiD3vbLTp+3RdezizT6GXFU=; h=Message-ID:Date:MIME-Version:To:From; b=LetrJpRz51reWBCl11KhcMGG9Q3LvjH/SVGisioxwEitaMmv4oBH76C3MGRXmoZ4q s32hAK/5iLYEQ0gfypUs1ivIoVYwNV1Fh0pUw80TSCPRQE4NizrZDw08g8ry5+M89l dSDKUtJWAcBMQ+sB3EFZqTrcfWYz+ZzDac33T8vulqDveqLCAMqDY+trDWXSwsaQRf h/1BwS2DAGvmaRbo+pJ79L376SppqPzIn5J6wOMihM8AQLbxcgUgzzZO+LqAoKPgl0 MK3p8BHhlMhayZXfBNQwTYyMK3Vj3gDW6CYuK9xq6hAorwnNdNCMLAMo3VYwRGogHS S0auHcZMoRT3Q== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id The5MGcRsRIU; Wed, 7 Feb 2024 13:22:47 -0800 (PST) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id B06E73C011BC5; Wed, 7 Feb 2024 13:22:47 -0800 (PST) Content-Language: en-US In-Reply-To: <4e0c6b19-07bc-fbc5-4e4c-df2b088db4cb@draconx.ca> Received-SPF: pass client-ip=131.179.128.66; envelope-from=eggert@cs.ucla.edu; helo=mail.cs.ucla.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: autoconf-patches@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Patches for autoconf - the GNU build system <autoconf-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/autoconf-patches>, <mailto:autoconf-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/autoconf-patches> List-Post: <mailto:autoconf-patches@gnu.org> List-Help: <mailto:autoconf-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/autoconf-patches>, <mailto:autoconf-patches-request@gnu.org?subject=subscribe> Errors-To: autoconf-patches-bounces+gnu-autoconf-patches=m.gmane-mx.org@gnu.org Original-Sender: autoconf-patches-bounces+gnu-autoconf-patches=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.comp.sysutils.autoconf.patches:9052 gmane.emacs.devel:316001 Archived-At: <http://permalink.gmane.org/gmane.comp.sysutils.autoconf.patches/9052> This is a multi-part message in MIME format. --------------E5NEkfo07FfZXRqx6DlmdUz4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/6/24 20:37, Nick Bowler wrote: > On 2024-02-06 22:33, Sam James wrote: >> Noticed when building Emacs: >> ``` >> * checking type of array argument to getgroups... ./configure: 42782: test: =: unexpected operator >> ``` > Oh look, I see this line in emacs-29.2/configure.ac: > > AC_DEFUN([AC_TYPE_UID_T]) > > This is the actual cause of the problem, because AC_TYPE_UID_T is the > part of Autoconf that would have assigned this variable. Since Emacs > has deleted its definition, it has therefore broken other Autoconf > macros (like AC_TYPE_GETGROUPS) which depend on it. Thanks for reporting this. I installed the attached patch into Emacs master. The now-fixed bug in Emacs's generated 'configure' script should be harmless on all platforms I know about, as AC_TYPE_GETGROUPS should go ahead and do the right thing anyway. PS. There is a case for quoting all uses of ac_cv_* variables, as their values may be corrupted in the cache. This is my usual style elsewhere and perhaps Autoconf should adopt it. Of course if we'd done that we would likely never have spotted this harmless error in Emacs configure.ac.... --------------E5NEkfo07FfZXRqx6DlmdUz4 Content-Type: text/x-patch; charset=UTF-8; name="0001-Port-better-to-Autoconf-2.72.patch" Content-Disposition: attachment; filename="0001-Port-better-to-Autoconf-2.72.patch" Content-Transfer-Encoding: base64 RnJvbSBlMzRlYmMwY2NjNmMyN2U3ZTEyMTdiYWFkOWNhNzRkZDdiZWE0YzM3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDcgRmViIDIwMjQgMTM6MTc6NTcgLTA4MDAKU3ViamVjdDogW1BBVENI XSBQb3J0IGJldHRlciB0byBBdXRvY29uZiAyLjcyCgoqIGNvbmZpZ3VyZS5hYzogU2V0IGFj X2N2X3R5cGVfZ2lkX3Q9eWVzIHRvIHBhY2lmeSBBdXRvY29uZiAyLjcyCkFDX1RZUEVfR0VU R1JPVVBTLiAgUHJvYmxlbSByZXBvcnRlZCBieSBOaWNrIEJvd2xlciBpbjoKaHR0cHM6Ly9s aXN0cy5nbnUub3JnL3IvYXV0b2NvbmYtcGF0Y2hlcy8yMDI0LTAyL21zZzAwMDAxLmh0bWwK LS0tCiBjb25maWd1cmUuYWMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KQoKZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBiNzRl YmE4NzlhYi4uODQ3ZmRiZDU0ZDIgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9j b25maWd1cmUuYWMKQEAgLTIzMzcsNiArMjMzNyw3IEBAIEFDX0RFRlVOCiBBQ19ERUZVTihb QUNfVFlQRV9TSVpFX1RdKQogIyBMaWtld2lzZSBmb3Igb2Jzb2xlc2NlbnQgdGVzdCBmb3Ig dWlkX3QsIGdpZF90OyBFbWFjcyBhc3N1bWVzIHRoZW0uCiBBQ19ERUZVTihbQUNfVFlQRV9V SURfVF0pCithY19jdl90eXBlX2dpZF90PXllcyAjIEFDX1RZUEVfR0VUR1JPVVBTIG5lZWRz IHRoaXMgaW4gQXV0b2NvbmYgMi43Mi4KIAogIyBDaGVjayBmb3IgYWxsIG1hdGguaCBmdW5j dGlvbnMgdGhhdCBFbWFjcyB1c2VzOyBvbiBzb21lIHBsYXRmb3JtcywKICMgLWxtIGlzIG5l ZWRlZCBmb3Igc29tZSBvZiB0aGVzZSBmdW5jdGlvbnMuCi0tIAoyLjQzLjAKCg== --------------E5NEkfo07FfZXRqx6DlmdUz4--