From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: wait_reading_process_ouput hangs in certain cases (w/ patches) Date: Sun, 19 Nov 2017 09:06:07 -0800 Organization: UCLA Computer Science Department Message-ID: <01d9f188-a382-071d-7b84-bdf798c2e3f4@cs.ucla.edu> References: <83tvyj62qg.fsf@gnu.org> <83r2tetf90.fsf@gnu.org> <5150d198-8dd3-9cf4-5914-b7e945294452@binary-island.eu> <83tvy7s6wi.fsf@gnu.org> <83inemrqid.fsf@gnu.org> <398f8d17-b727-d5d6-4a31-772448c7ca0d@binary-island.eu> <56e722a6-95a4-0e42-185c-f26845d4f4bf@binary-island.eu> <21237e45-a353-92f9-01ec-7b51640d2031@cs.ucla.edu> <83vaickfu2.fsf@gnu.org> <83tvxwkexg.fsf@gnu.org> <03261534-6bf5-1a5d-915f-d3c55aaa35e9@binary-island.eu> <206ebefa-7583-f049-140c-c8fd041b0719@cs.ucla.edu> <831skuff5x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1511111225 20954 195.159.176.226 (19 Nov 2017 17:07:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2017 17:07:05 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 Cc: ml_emacs-lists@binary-island.eu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 19 18:06:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGT3U-0004ib-85 for ged-emacs-devel@m.gmane.org; Sun, 19 Nov 2017 18:06:52 +0100 Original-Received: from localhost ([::1]:53773 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGT3b-0003Tj-NA for ged-emacs-devel@m.gmane.org; Sun, 19 Nov 2017 12:06:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGT31-0003Sg-3t for emacs-devel@gnu.org; Sun, 19 Nov 2017 12:06:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGT30-0003Yw-2z for emacs-devel@gnu.org; Sun, 19 Nov 2017 12:06:23 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52310) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eGT2u-0003UQ-Ij; Sun, 19 Nov 2017 12:06:16 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 10680161186; Sun, 19 Nov 2017 09:06:15 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id lF0nw35yCdpV; Sun, 19 Nov 2017 09:06:13 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C11BC16119A; Sun, 19 Nov 2017 09:06:13 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KR80mVfSpRZM; Sun, 19 Nov 2017 09:06:13 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9FE85161183; Sun, 19 Nov 2017 09:06:13 -0800 (PST) In-Reply-To: <831skuff5x.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220280 Archived-At: Eli Zaretskii wrote: >> Cc: emacs-devel@gnu.org >> From: Paul Eggert >> Date: Sat, 18 Nov 2017 23:07:37 -0800 >> >> * Fix the bug with carryover that I mentioned in >> . >=20 > Not sure what bug is that, and how would you propose to fix it. The bug is that with the patch as written, wait_reading_process_output mi= ght=20 return a positive value even though it didn't read anything (nor did any = timers=20 or filters). >> got_some_output =3D min (INT_MAX, (wait_proc->infd_num_bytes_read >> - initial_wait_proc_num_bytes_rea= d)); > If we are using uintmax_t, why limit this by INT_MAX? Because got_some_output is an int. And it's an int because the function's= =20 callers (either directly or indirectly) expect int. And the callers don't= care=20 what the value is, so long as it's positive (this is documented in the co= mments=20 describing wait_reading_process_output etc.). We could change got_some_output and all its users to employ the type intm= ax_t=20 rather than int, but even then we'd need to limit it to INTMAX_MAX, so wh= y=20 bother? It wouldn't fix any bugs.