From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el Date: Fri, 18 Jan 2019 22:28:07 +0300 Message-ID: <01d694c7-7e01-070f-82ab-f5db044eb467@yandex.ru> References: <20180922154639.23195.66360@vcs0.savannah.gnu.org> <20180922154640.9D58220310@vcs0.savannah.gnu.org> <54108dbc-9d12-06ff-3f1d-151118e9b234@yandex.ru> <385f6543-2214-101c-30b8-a8115a8dbede@yandex.ru> <87zhsi7mlt.fsf@mail.linkov.net> <07e843c5-70ea-20e6-96c9-263ea78e113f@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1547839576 20410 195.159.176.226 (18 Jan 2019 19:26:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Jan 2019 19:26:16 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Thunderbird/65.0 Cc: Juri Linkov , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 18 20:26:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkZmN-0005BC-66 for ged-emacs-devel@m.gmane.org; Fri, 18 Jan 2019 20:26:11 +0100 Original-Received: from localhost ([127.0.0.1]:45578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkZoU-0002TH-6x for ged-emacs-devel@m.gmane.org; Fri, 18 Jan 2019 14:28:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkZoN-0002T0-Kd for emacs-devel@gnu.org; Fri, 18 Jan 2019 14:28:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkZoL-0002NQ-Jz for emacs-devel@gnu.org; Fri, 18 Jan 2019 14:28:15 -0500 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:36183) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkZoL-0002Jb-A2 for emacs-devel@gnu.org; Fri, 18 Jan 2019 14:28:13 -0500 Original-Received: by mail-lf1-x131.google.com with SMTP id a16so11300147lfg.3 for ; Fri, 18 Jan 2019 11:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PdNdEF4ixLE0JO1OaJJhV26kOWPcRFDES3gyCIoUAIc=; b=s2MyG+Z6qcHtmYRM0FdAYE786B0ciS0uh4SbTglJE4bt0Qej3zeEuMebtyOK+sfwgN i1xaBljVZHNfxPMK0d4TYSEMlnxmB7XnJZDiLbmsjf1KKhb+zcvGLUgngY1IwwWv2JJz J0mH/RpOu8D2+uXjuqxPZJXN6KLf/V9Yhjk+Hd6DsJc4QZxeWkXtcg0vHSlhHlic30xS msK+xKn5Y2BI85OquAXOWuS1zSnY+QZkxIp3EJL/xf64bmfHlqfIQ/ZPD7JtIIaHtUIf xgI4whjoHqZ70YnqYgRSOjtSGp2/tnt7v2+o9pEvFylqZ/bhV3wpqvrOahGaYARY/eaW 2BgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PdNdEF4ixLE0JO1OaJJhV26kOWPcRFDES3gyCIoUAIc=; b=faf3eqcA8Tde6j5y/Vv4DVh52DOMKj3PPsY5O/zdjqa4YYpiydqJ82VBl7ks+jklZG ++Tv4t7Chsyzp12IgM6Bo5Je+veI0hfSeswKrrULtygPpPlNr22e+UGWCeByCl2ehysq bJwyyUo+XzOtVa3fm3/KdsfoSmzZgwGrtL1N82OTN6KxN9DJvamyzmp4z3hZpiZkENdk 1bOwS/szeQ+arPkPfbPGl7h7t2y0ydajE1GP+30dTHe191hJoUfAw/0ZN3aRGdRtGFZY ppuLyu3Ypwz8ttPubM3Uj33154iM2fZkmoTHDzPXPHHyJP8QsmzxqM3kLbn1iwHaW6cr J2aQ== X-Gm-Message-State: AJcUukeM8d6zQz50NfwMKG76Dw4lgMbMwjbC6ciUGoU+vBzG92x3+mrQ cfKsobgKOG41K6+zzYY+2cE= X-Google-Smtp-Source: ALg8bN4pvI5XxemuUqY+I5s34u84PTg7GrqdUS0bW7/5+ljgbmNq32Hm+ekshLQRGA3VCI3HwHDJ0g== X-Received: by 2002:a19:7352:: with SMTP id o79mr14069640lfc.104.1547839690583; Fri, 18 Jan 2019 11:28:10 -0800 (PST) Original-Received: from [192.168.0.108] ([79.175.3.65]) by smtp.googlemail.com with ESMTPSA id 85-v6sm898694lja.16.2019.01.18.11.28.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 11:28:09 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::131 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232459 Archived-At: On 18.01.2019 15:49, Stefan Monnier wrote: >> I'm not adding this to master because this does not support >> project-vc-ignores (or grep-find-ignored-files). > > Not sure why you think it should obey grep-find-ignored-files, but You're probably right, .gitignore should already include the necessary entries anyway. I'll simplify the definition of project-ignores for the vc backend. > I think the project-vc-ignores variable is an error: project-vc-ignores > should be a function that returns the set of files ignored by the > underlying VCS, not something that the user sets in Emacs. You're thinking of project-ignores. project-vc-ignores is a variable for the user to be able to tweak that list. Other editors such as Atom and VS Code have a section in the preferences for this, but The sets of files that are checked into the repository and the files that the user might like to visit or search are not necessarily the same. For instance, it's common practice where I work to check in sample config files and add the "real" file names to the ignores. Example: database.yml.sample is checked into Git, and database.yml is in gitignore (this file the user creates locally using the sample file as an example). But they'll want to visit and search that file anyway. And vice versa, there can be files inside the repository which the particular user would prefer to ignore most of the time. For me, that's usually web assets, minified JS libs, etc (I don't write JS these days anyway) and files with recorded HTTP interactions (there are lots of them, and they have very long names, so any fuzzy search against file names would often hit several of them, slowing ido-find-file down). Further, we might even choose not to use .gitignore contents in this operation and simply filter out some standard list (plus globs defined by user preference). Because if somebody decides to implement a file explorer using project-files, or only visit files using project-find-file, they might be surprised to see certain files missing. Not all ignored files are machine-generated, and even those need to be verified sometimes.