* Customizing Buffer-menu-buffer-face
@ 2005-05-14 7:40 martin rudalics
2005-05-15 0:21 ` Richard Stallman
2005-05-15 0:21 ` Richard Stallman
0 siblings, 2 replies; 5+ messages in thread
From: martin rudalics @ 2005-05-14 7:40 UTC (permalink / raw)
Is there any reason why `Buffer-menu-buffer-face' is customized in the
`font-lock-highlighting-faces' group? The current choice (i) breaks the
convention that all faces in this group are prefixed with "font-lock-"
and (ii) falsely implies that this face is used by font-lock. Since
the face is used in the mode-line why not customize it in the mode-line
group?
Similarly, what's the purpose of customizing `show-trailing-whitespace'
and `trailing-whitespace' in the font-lock group?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Customizing Buffer-menu-buffer-face
2005-05-14 7:40 Customizing Buffer-menu-buffer-face martin rudalics
@ 2005-05-15 0:21 ` Richard Stallman
2005-05-15 0:21 ` Richard Stallman
1 sibling, 0 replies; 5+ messages in thread
From: Richard Stallman @ 2005-05-15 0:21 UTC (permalink / raw)
Cc: emacs-devel
Is there any reason why `Buffer-menu-buffer-face' is customized in the
`font-lock-highlighting-faces' group? The current choice (i) breaks the
convention that all faces in this group are prefixed with "font-lock-"
and (ii) falsely implies that this face is used by font-lock.
With the existing code, there is no reason. However, that's due
to a bug. Fixing the bug, with the patch below, it becomes
the case that M-x font-lock-mode controls whether this face
is actually used. And then it makes sense to put this in the
group font-lock-highlighting-faces.
However, it should also be in the group Buffer-menu.
*** buff-menu.el 09 Apr 2005 19:50:08 -0400 1.80
--- buff-menu.el 14 May 2005 14:06:54 -0400
***************
*** 77,82 ****
--- 77,83 ----
(defface Buffer-menu-buffer-face
'((t (:weight bold)))
"Face used to highlight buffer name."
+ :group 'Buffer-menu
:group 'font-lock-highlighting-faces)
(defcustom Buffer-menu-buffer+size-width 26
***************
*** 754,760 ****
(int-to-string (nth 3 buffer))
`(buffer-name ,(nth 2 buffer)
buffer ,(car buffer)
! face Buffer-menu-buffer-face
mouse-face highlight
help-echo "mouse-2: select this buffer"))
" "
--- 755,761 ----
(int-to-string (nth 3 buffer))
`(buffer-name ,(nth 2 buffer)
buffer ,(car buffer)
! font-lock-face Buffer-menu-buffer-face
mouse-face highlight
help-echo "mouse-2: select this buffer"))
" "
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Customizing Buffer-menu-buffer-face
2005-05-14 7:40 Customizing Buffer-menu-buffer-face martin rudalics
2005-05-15 0:21 ` Richard Stallman
@ 2005-05-15 0:21 ` Richard Stallman
2005-05-15 3:58 ` Eli Zaretskii
1 sibling, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2005-05-15 0:21 UTC (permalink / raw)
Cc: emacs-devel
Similarly, what's the purpose of customizing `show-trailing-whitespace'
and `trailing-whitespace' in the font-lock group?
I will move them to `convenience'. Or is there some other group
that would be better?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Customizing Buffer-menu-buffer-face
2005-05-15 0:21 ` Richard Stallman
@ 2005-05-15 3:58 ` Eli Zaretskii
2005-05-15 22:39 ` Richard Stallman
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2005-05-15 3:58 UTC (permalink / raw)
Cc: rudalics, emacs-devel
> From: Richard Stallman <rms@gnu.org>
> Date: Sat, 14 May 2005 20:21:20 -0400
> Cc: emacs-devel@gnu.org
>
> Similarly, what's the purpose of customizing `show-trailing-whitespace'
> and `trailing-whitespace' in the font-lock group?
>
> I will move them to `convenience'. Or is there some other group
> that would be better?
IMHO, `convenience' is too general; I, for one, would not think about
looking for these in that group. The following groups sound like
better candidates:
display, faces, font-lock-highlighting-faces,
whitespace, whitespace-faces
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Customizing Buffer-menu-buffer-face
2005-05-15 3:58 ` Eli Zaretskii
@ 2005-05-15 22:39 ` Richard Stallman
0 siblings, 0 replies; 5+ messages in thread
From: Richard Stallman @ 2005-05-15 22:39 UTC (permalink / raw)
Cc: rudalics, emacs-devel
IMHO, `convenience' is too general; I, for one, would not think about
looking for these in that group. The following groups sound like
better candidates:
display, faces, font-lock-highlighting-faces,
whitespace, whitespace-faces
The last two seem good.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-05-15 22:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-14 7:40 Customizing Buffer-menu-buffer-face martin rudalics
2005-05-15 0:21 ` Richard Stallman
2005-05-15 0:21 ` Richard Stallman
2005-05-15 3:58 ` Eli Zaretskii
2005-05-15 22:39 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).