From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: /lib/cpp not found in c-mode Date: Sun, 08 May 2005 22:02:25 +0300 Message-ID: <01c55400$Blat.v2.4$9e886800@zahav.net.il> References: <17013.26868.207510.370151@farnswood.snap.net.nz> <17013.52411.51878.781739@farnswood.snap.net.nz> <17014.39042.74353.677362@farnswood.snap.net.nz> <87d5s8144e.fsf@zemdatav.stor.no-ip.org> <17017.13673.613123.524633@farnswood.snap.net.nz> <87ll6tn4hh.fsf-monnier+emacs@gnu.org> <01c5519b$Blat.v2.4$0c9b1d00@zahav.net.il> <17018.35323.755067.631608@farnswood.snap.net.nz> <01c55238$Blat.v2.4$0e1c2960@zahav.net.il> <87ll6pk4o0.fsf-monnier+emacs@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1115580691 13191 80.91.229.2 (8 May 2005 19:31:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 8 May 2005 19:31:31 +0000 (UTC) Cc: mange@freemail.hu, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 08 21:31:26 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DUrUR-0002uo-Nl for ged-emacs-devel@m.gmane.org; Sun, 08 May 2005 21:31:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DUrcc-0000xF-TD for ged-emacs-devel@m.gmane.org; Sun, 08 May 2005 15:39:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DUrYq-0005us-Li for emacs-devel@gnu.org; Sun, 08 May 2005 15:35:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DUrYo-0005uF-2W for emacs-devel@gnu.org; Sun, 08 May 2005 15:35:30 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DUrY4-00054D-Cw for emacs-devel@gnu.org; Sun, 08 May 2005 15:34:44 -0400 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DUrKT-0003Fj-CI for emacs-devel@gnu.org; Sun, 08 May 2005 15:20:41 -0400 Original-Received: from zaretski (IGLD-83-130-243-144.inter.net.il [83.130.243.144]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id EHZ55972 (AUTH halo1); Sun, 8 May 2005 22:04:59 +0300 (IDT) Original-To: Stefan Monnier X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 In-reply-to: <87ll6pk4o0.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 08 May 2005 13:31:20 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36878 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36878 > Cc: Nick Roberts , mange@freemail.hu, > emacs-devel@gnu.org > From: Stefan Monnier > Date: Sun, 08 May 2005 13:31:20 -0400 > > Actually, looking at the definition of executable-find, I'm surprised it > doesn't use locate-file. IIRC, executable-find was in existence longe before you added locate-file. > The new code is nothing else than a call to locate-file and I'd argue > that Eli's change from executable-find to locate-file is a bad idea and > instead we should simply move executable-find from executable.el to > subr.el. Well, if you are going to use integer values as the last arg to locate-file (which is deprecated usage, as the doc string says), why not call locate-file-internal directly and save a few cycles? Also, I think this should go into files.el, not subr.el, since locate-file is in files.el. Other than that, I don't mind; I think that executable-find indeed doesn't belong in executable.el.