From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Overlay arrow in *compilation* and *grep* buffers Date: Sun, 24 Apr 2005 13:45:35 +0300 Message-ID: <01c548ba$Blat.v2.4$e4827900@zahav.net.il> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1114339408 19391 80.91.229.2 (24 Apr 2005 10:43:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2005 10:43:28 +0000 (UTC) Cc: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 24 12:43:26 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DPea2-0005aZ-Jz for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2005 12:43:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DPefK-0008E2-Ss for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2005 06:48:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DPeeZ-0008Cx-KY for emacs-devel@gnu.org; Sun, 24 Apr 2005 06:47:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DPeeY-0008Cl-CA for emacs-devel@gnu.org; Sun, 24 Apr 2005 06:47:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DPeeX-0007ex-0P for emacs-devel@gnu.org; Sun, 24 Apr 2005 06:47:53 -0400 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DPegf-0007H5-T3 for emacs-devel@gnu.org; Sun, 24 Apr 2005 06:50:06 -0400 Original-Received: from zaretski (IGLD-80-230-58-44.inter.net.il [80.230.58.44]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id BBI85850 (AUTH halo1); Sun, 24 Apr 2005 13:46:56 +0300 (IDT) Original-To: emacs-devel@gnu.org X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36323 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36323 A couple of weeks ago, a change to compile.el introduced an overlay arrow into buffers created by compile.el: the overlay arrow now marks the current line in the compilation buffer. (Here, ``current line'' means the line whose locus is displayed in the other window; next-error and mouse-1 change that line.) At least on a text terminal, this feature is problematic. First, suppose that "M-x compile" produced the following *compilation* buffer (I indent the buffer contents 2 columns to the right to make it stand out): -*- mode: compilation; default-directory: "~/" -*- gcc -Wall -O -c tfwd.c tfwd.c: In function `foo': tfwd.c:5: warning: implicit declaration of function `bar' tfwd.c: At top level: tfwd.c:11: warning: type mismatch with previous implicit declaration tfwd.c:5: warning: previous implicit declaration of `bar' tfwd.c:11: warning: `bar' was previously implicitly declared to return `int' tfwd.c: In function `bar': tfwd.c:13: warning: implicit declaration of function `callme' tfwd.c: At top level: tfwd.c:4: warning: `foo' defined but not used Compilation finished at Sun Apr 24 06:01:25 Now, if I type "C-x `", the window that displays the compilation buffer looks like this: =>wd.c:5: warning: implicit declaration of function `bar' tfwd.c: At top level: tfwd.c:11: warning: type mismatch with previous implicit declaration tfwd.c:5: warning: previous implicit declaration of `bar' tfwd.c:11: warning: `bar' was previously implicitly declared to return `int' tfwd.c: In function `bar': tfwd.c:13: warning: implicit declaration of function `callme' tfwd.c: At top level: tfwd.c:4: warning: `foo' defined but not used Compilation finished at Sun Apr 24 06:01:25 Notice the overlay arrow that covered part of the file name: this is a bug, IMHO. If we want to have an arrow pointing out the current line, we should indent the buffer text to the right as many columns as the arrow string takes. Moreover, next-error scrolls the display to keep the current line at the top of the window. I think it's a bit silly to mark the with an arrow a line that is always at the top of its window; such an arrow might make sense if we do not scroll the window except when the current line is no longer visible. Perhaps we need a user option to control these two features (scrolling and arrow) in a way that would by default prevent scrolling when the arrow is used to show the current line. Also, the arrow feature is not customizable. What about users who will dislike it and would wish to turn it off? Finally, I don't really understand why new features such as this one get installed while we are in a feature freeze. At the very least, it should have been discussed (such a discussion could also lead to better design decisions wrt scrolling). However, I couldn't find anything related in emacs-devel archives (sorry if I missed something).