From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: face colors on 256 colors terminals Date: Thu, 07 Apr 2005 06:53:28 +0300 Message-ID: <01c53b25$Blat.v2.4$80e8db20@zahav.net.il> References: <200504060817.j368HDAH019106@scanner2.ics.uci.edu> <01c53acd$Blat.v2.4$7c0f2080@zahav.net.il> <200504062134.j36LY8AH022227@scanner2.ics.uci.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1112846236 14661 80.91.229.2 (7 Apr 2005 03:57:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 7 Apr 2005 03:57:16 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 07 05:57:14 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DJO8e-0004od-7e for ged-emacs-devel@m.gmane.org; Thu, 07 Apr 2005 05:57:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DJNhs-0000yA-3f for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2005 23:29:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DJNhS-0000po-Gc for emacs-devel@gnu.org; Wed, 06 Apr 2005 23:29:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DJNhS-0000pJ-E0 for emacs-devel@gnu.org; Wed, 06 Apr 2005 23:28:58 -0400 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DJOAM-00075t-Ux for emacs-devel@gnu.org; Wed, 06 Apr 2005 23:58:51 -0400 Original-Received: from zaretski (IGLD-80-230-67-97.inter.net.il [80.230.67.97]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id AXT47117 (AUTH halo1); Thu, 7 Apr 2005 06:58:04 +0300 (IDT) Original-To: Dan Nicolaescu X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 In-reply-to: <200504062134.j36LY8AH022227@scanner2.ics.uci.edu> (message from Dan Nicolaescu on Wed, 06 Apr 2005 14:34:06 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:35675 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35675 > Cc: emacs-devel@gnu.org > From: Dan Nicolaescu > Date: Wed, 06 Apr 2005 14:34:06 -0700 > > "Eli Zaretskii" writes: > > > > From: Dan Nicolaescu > > > Some standard face definitions use colors like "red" or "blue". They > > > should be changed "red1" (or "blue1") > > > > Yes, I agree. Can you post a patch to do that? > > Here it is. It replaces: > red->red1 > green->green1 > blue->blue1 > yellow->yellow1 > cyan->cyan1 > magenta->magenta1 > > The replacements were done so that not change anything for faces that > had a special treatment for ttys, pc, etc. Thanks. > Is this OK? > > Index: lisp/comint.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/comint.el,v > retrieving revision 1.310 > diff -c -3 -p -r1.310 comint.el > *** lisp/comint.el 5 Apr 2005 01:21:23 -0000 1.310 > --- lisp/comint.el 6 Apr 2005 21:24:52 -0000 > *************** This variable is buffer-local." > *** 228,234 **** > :group 'comint) > > (defface comint-highlight-prompt > ! '((((background dark)) (:foreground "cyan")) > (t (:foreground "dark blue"))) > "Face to use to highlight prompts." > :group 'comint) > --- 228,234 ---- > :group 'comint) > > (defface comint-highlight-prompt > ! '((((background dark)) (:foreground "cyan1")) > (t (:foreground "dark blue"))) > "Face to use to highlight prompts." > :group 'comint) Hmmm... "bother", as they say. The changes to the face colors that are under (min-colors 88) or when there's a separate color for less color-capable displays are okay. But there are few cases where there's a single color definition, like the one above, which is applicable to all color-capable displays. In these cases, the changes you suggest will have a significant effect on 16-color text terminals, because cyan1, blue1, red1 etc. are translated to the bright shades of the respective colors, so what was red will now be brightred. The bright shades are quite annoying in many situations. So I think we should change this patch so as not to change the color definitions on displays that support less than 88 colors. That is, in those cases where there's a single color definition, split it into 2 and change only the one for >88 colors.