From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Sat, 12 Mar 2005 12:01:29 +0200 Message-ID: <01c526ea$Blat.v2.4$9b90fba0@zahav.net.il> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> <01c52655$Blat.v2.4$b47b9200@zahav.net.il> <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> <534dd629871884654f6c43846c34db9a@swipnet.se> <00f501c5266a$1bf72de0$0200a8c0@sedrcw11488> <01c5267c$Blat.v2.4$37bc1380@zahav.net.il> <010601c5269f$660e83d0$0200a8c0@sedrcw11488> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1110622031 5222 80.91.229.2 (12 Mar 2005 10:07:11 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2005 10:07:11 +0000 (UTC) Cc: hunterd42@comcast.net, kobayays@otsukakj.co.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 11:07:10 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DA3WN-0001MS-7k for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2005 11:06:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DA3lc-0005Ey-G0 for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2005 05:22:44 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DA3kF-00059z-9w for emacs-devel@gnu.org; Sat, 12 Mar 2005 05:21:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DA3kB-00058f-J7 for emacs-devel@gnu.org; Sat, 12 Mar 2005 05:21:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DA3kB-00058N-0J for emacs-devel@gnu.org; Sat, 12 Mar 2005 05:21:15 -0500 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DA3Tc-00061W-AV for emacs-devel@gnu.org; Sat, 12 Mar 2005 05:04:08 -0500 Original-Received: from zaretski (tony02-27-42.inter.net.il [80.230.27.42]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id DXM67561 (AUTH halo1); Sat, 12 Mar 2005 12:03:51 +0200 (IST) Original-To: "Lennart Borgman" X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 In-reply-to: <010601c5269f$660e83d0$0200a8c0@sedrcw11488> (lennart.borgman.073@student.lu.se) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34505 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34505 > From: "Lennart Borgman" > Cc: , , > , > Date: Sat, 12 Mar 2005 02:03:45 +0100 > > From: "Eli Zaretskii" > > > I don't see how this is more readable. One cannot understand the > > meaning of HAVE_HOURGLASS without grepping thru lots of places. > > Hm ;-) > > There is something I do not understand in your argument. How about > HAVE_MOUSE, HAVE_SOUND? These are configure-time definitions, unlike HAVE_HOURGLASS. They test the basic capabilities of the underlying platform, while HAVE_HOURGLASS tells something about Emacs support of the feature, not about its availability on the platform. > > #if defined (USE_X_TOOLKIT) || defined (HAVE_NTGUI) > > > > So this is clearly an accepted practice in Emacs. > > I find it very hard to guess what this define is for without reading the > code. Using names like HAVE_MOUSE, HAVE_HOURGLASS makes it much more easy to > guess IMO. And I think that is important if you are scanning the code > quickly trying to find things, see the structure etc. It may of course > depend on how you are thinking, but for me this makes sense. I would guess > it makes sense for a lot of other people too (but I am of course not sure.) Jason responded with a clear and eloquent explanation, and I can only say I agree with him 100%.