From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Fri, 11 Mar 2005 22:51:17 +0200 Message-ID: <01c5267c$Blat.v2.4$37bc1380@zahav.net.il> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> <01c52655$Blat.v2.4$b47b9200@zahav.net.il> <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> <534dd629871884654f6c43846c34db9a@swipnet.se> <00f501c5266a$1bf72de0$0200a8c0@sedrcw11488> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1110575683 4029 80.91.229.2 (11 Mar 2005 21:14:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2005 21:14:43 +0000 (UTC) Cc: hunterd42@comcast.net, emacs-devel@gnu.org, kobayays@otsukakj.co.jp, jasonr@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 22:14:42 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9rLm-0003hD-3c for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 22:07:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9rZM-0005Hv-HM for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 16:21:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9rYS-0005E7-Hn for emacs-devel@gnu.org; Fri, 11 Mar 2005 16:20:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9rYP-0005Cu-4N for emacs-devel@gnu.org; Fri, 11 Mar 2005 16:20:18 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9rYP-0005Cr-0V for emacs-devel@gnu.org; Fri, 11 Mar 2005 16:20:17 -0500 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D9r8n-0007PQ-9D; Fri, 11 Mar 2005 15:53:49 -0500 Original-Received: from zaretski (tony02-27-42.inter.net.il [80.230.27.42]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id DXL36631 (AUTH halo1); Fri, 11 Mar 2005 22:53:36 +0200 (IST) Original-To: "Lennart Borgman" X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 In-reply-to: <00f501c5266a$1bf72de0$0200a8c0@sedrcw11488> (lennart.borgman.073@student.lu.se) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34491 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34491 > From: "Lennart Borgman" > Date: Fri, 11 Mar 2005 19:42:25 +0100 > Cc: hunterd42@comcast.net, Eli Zaretskii , jasonr@gnu.org, > kobayays@otsukakj.co.jp, emacs-devel@gnu.org > > From: "Jan D." > > > > I believe HAVE_HOURGLASS should go into src\config.in. There is > > > already an > > > #ifdef HAVE_X_WINDOWS and I suggest putting something like this after > > > that > > > define: > > > > > > /* This is for the hourglass code in various files. */ > > > #if defined(HAVE_X_WINDOWS) || defined(HAVE_NTGUI) > > > #define HAVE_HOURGLASS > > > #endif src/config.in is a generated file, so you should not make any changes in it, anyway. > > > IMO it will be more readable and if you want to add hourglass code for > > > other systems some day it is easier. I don't see how this is more readable. One cannot understand the meaning of HAVE_HOURGLASS without grepping thru lots of places. > > But the w32 port does not expand config.in to config.h AFAIK, so this > > does nothing when building on w32. > > Thanks. For w32 there is instead a config.nt where this should go too. But why do this? What good will this do? All it does is spread the information between several differeint files, instead of keeping it together, and on top of that, it adds a useless change in config.in (since the Windows build doesn't use it). I don't see any benefit in such pseudo-configured stuff. We already have pieces of code that are conditioned similarly, e.g.: #if defined (USE_X_TOOLKIT) || defined (HAVE_NTGUI) So this is clearly an accepted practice in Emacs.