From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Fri, 11 Mar 2005 15:28:46 +0200 Message-ID: <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1110547947 2927 80.91.229.2 (11 Mar 2005 13:32:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2005 13:32:27 +0000 (UTC) Cc: hunterd42@comcast.net, kobayays@otsukakj.co.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 14:32:26 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9kFE-0001ZX-Se for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 14:32:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9kUK-0006GI-1N for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 08:47:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9kTn-00067d-2H for emacs-devel@gnu.org; Fri, 11 Mar 2005 08:47:03 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9kTk-00066X-Cg for emacs-devel@gnu.org; Fri, 11 Mar 2005 08:47:02 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9kTk-00066G-6L for emacs-devel@gnu.org; Fri, 11 Mar 2005 08:47:00 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D9kEW-00059d-Ea for emacs-devel@gnu.org; Fri, 11 Mar 2005 08:31:16 -0500 Original-Received: from zaretski (tony02-27-42.inter.net.il [80.230.27.42]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id ASE25717 (AUTH halo1); Fri, 11 Mar 2005 15:31:02 +0200 (IST) Original-To: "Lennart Borgman" X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 In-reply-to: <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> (lennart.borgman.073@student.lu.se) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34469 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34469 > From: "Lennart Borgman" > Cc: "Eli Zaretskii" , , > "Jan D." , > "David Hunter" , > "Jason Rumney" , > "KOBAYASHI Yasuhiro" > Date: Fri, 11 Mar 2005 00:33:16 +0100 > > > > Personally, I think we are fine as we are now. Of course, if you > > > implement start_hourglass et al for Windows, the HAVE_X_WINDOWS > > > condition needs to be augmented by something that will enable it for > > > Windows. > > > > Yes, I thought I would implement start_hourglass etc. Maybe someone wants > > to implement it in macfns.c too where the body part also has an empty body > > part. > > > > Whichever way of changing the current "#ifdef HAVE_X_WINDOWS" at those > > places are enough, but removing the ifdef:s and adding a file with empty > > body parts for those ports that does not implement hourglass support makes > > the code easier to read IMO. > > I have implemented code for hourglass on w32 now (or rather I should say > Dave Hunter has done it, I just did a small amount of typing). Could we > please get a decision on the issue above so that it is possible to get this > working with the CVS code? (The hourglass code in keyboard.c is currently > only called if HAVE_X_WINDOWS is defined.) I suggest adding WINDOWSNT to HAVE_X_WINDOWS in the condition for calling the hourglass code. Would that resolve the issue?