From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Tue, 01 Mar 2005 01:05:30 +0200 Message-ID: <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1109632084 16402 80.91.229.2 (28 Feb 2005 23:08:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 28 Feb 2005 23:08:04 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 01 00:08:04 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D5tzE-0002SY-OW for ged-emacs-devel@m.gmane.org; Tue, 01 Mar 2005 00:07:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D5uHg-0004As-7y for ged-emacs-devel@m.gmane.org; Mon, 28 Feb 2005 18:26:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D5uEK-0003LK-KT for emacs-devel@gnu.org; Mon, 28 Feb 2005 18:23:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D5uE8-0003DT-4l for emacs-devel@gnu.org; Mon, 28 Feb 2005 18:23:03 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D5uE6-0003CO-Pn for emacs-devel@gnu.org; Mon, 28 Feb 2005 18:22:58 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D5tyu-0003XQ-LJ for emacs-devel@gnu.org; Mon, 28 Feb 2005 18:07:16 -0500 Original-Received: from zaretski (IGLD-84-228-249-66.inter.net.il [84.228.249.66]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id AQJ04821 (AUTH halo1); Tue, 1 Mar 2005 01:07:07 +0200 (IST) Original-To: "Lennart Borgman" X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 In-reply-to: <007801c51dae$4674c560$0200a8c0@sedrcw11488> (lennart.borgman.073@student.lu.se) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:33955 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:33955 > From: "Lennart Borgman" > Cc: > Date: Mon, 28 Feb 2005 16:57:26 +0100 > > What I was trying to say was this (that it probably are conditioned for X) > and that it is a problem because with > #ifdef HAVE_X_WINDOWS > around hourglass activation/deactivation you can only get things working on > X. Which is fine, as long as other platforms don't implement the required infrastructure. > For the w32 port there are also > #if 0 > around the body part of the functions that do the actual job > (start_hourglass, hide_hourglass), since it is (as far as I understand) not > implemented on w32 yet. Exactly. > I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I > believe most would like better - but not I) replacing them with something > like > > #ifdef HAS_HOURGLASS We cannot do the former without adding (possibly empty) functions called by those snippets to all ports. And we cannot do the latter without adding some configury stuff that would determine the value of HAS_HOURGLASS at configure time. Personally, I think we are fine as we are now. Of course, if you implement start_hourglass et al for Windows, the HAVE_X_WINDOWS condition needs to be augmented by something that will enable it for Windows.