From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Buttons in Customize buffers Date: Sat, 22 Jan 2005 13:24:29 +0200 Message-ID: <01c50075$Blat.v2.4$15983f40@zahav.net.il> Reply-To: Eli Zaretskii NNTP-Posting-Host: deer.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1106393689 26174 80.91.229.6 (22 Jan 2005 11:34:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 22 Jan 2005 11:34:49 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 22 12:34:43 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CsJXP-0004Yw-00 for ; Sat, 22 Jan 2005 12:34:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CsJjW-0001Ed-1B for ged-emacs-devel@m.gmane.org; Sat, 22 Jan 2005 06:47:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CsJio-000165-V8 for emacs-devel@gnu.org; Sat, 22 Jan 2005 06:46:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CsJim-00014Y-Eh for emacs-devel@gnu.org; Sat, 22 Jan 2005 06:46:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CsJil-00013R-5i for emacs-devel@gnu.org; Sat, 22 Jan 2005 06:46:27 -0500 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CsJRh-0001gd-NM for emacs-devel@gnu.org; Sat, 22 Jan 2005 06:28:50 -0500 Original-Received: from zaretski (IGLD-83-130-252-165.inter.net.il [83.130.252.165]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id DPA04946 (AUTH halo1); Sat, 22 Jan 2005 13:28:47 +0200 (IST) Original-To: emacs-devel@gnu.org X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 2.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:32486 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:32486 Buttons in Customize buffers used to have a special mouse-face, but that was removed in favor of changing the mouse pointer shape by this change: 2004-06-08 Kim F. Storm * wid-edit.el (widget-specify-button): Use hand pointer rather than mouse-face as visible mouse-over effect. That is okay for graphics displays, but not for mouse-capable text terminals, since the latter cannot change the mouse pointer shape. The MS-DOS terminal is one case, but I'm guessing that non-windows sessions on an xterm with xt-mouse loaded are suffering from the same problem. Is the following change okay to install? Index: lisp/wid-edit.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/wid-edit.el,v retrieving revision 1.134 diff -u -r1.134 wid-edit.el --- lisp/wid-edit.el 27 Dec 2004 16:38:57 -0000 1.134 +++ lisp/wid-edit.el 22 Jan 2005 11:22:52 -0000 @@ -391,7 +391,11 @@ (overlay-put overlay 'evaporate t) ;; We want to avoid the face with image buttons. (unless (widget-get widget :suppress-face) - (overlay-put overlay 'face (widget-apply widget :button-face-get))) + (overlay-put overlay 'face (widget-apply widget :button-face-get)) + ; Text terminals cannot change mouse pointer shape, so use mouse + ; face instead. + (or (display-graphic-p) + (overlay-put overlay 'mouse-face widget-mouse-face))) (overlay-put overlay 'pointer 'hand) (overlay-put overlay 'follow-link follow-link) (overlay-put overlay 'help-echo help-echo)))