From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-trunk-diffs] Changes to emacs/lisp/faces.el Date: Tue, 28 Dec 2004 00:01:51 +0200 Message-ID: <01c4ec5f$Blat.v2.2.2$d17a06a0@zahav.net.il> References: <87mzwsws3d.fsf@jurta.org> <41B6317B.6020303@esperanto.org> <41BC0D29.9020007@t-online.de> <87sm5wfhh3.fsf@jurta.org> <87ekhcsurb.fsf@jurta.org> <01c4ebea$Blat.v2.2.2$4d937300@zahav.net.il> <87r7lbikl4.fsf@jurta.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: deer.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1104185697 7670 80.91.229.6 (27 Dec 2004 22:14:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Dec 2004 22:14:57 +0000 (UTC) Cc: bob@rattlesnake.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 27 23:14:51 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Cj38d-00044L-00 for ; Mon, 27 Dec 2004 23:14:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cj3JR-00080k-JO for ged-emacs-devel@m.gmane.org; Mon, 27 Dec 2004 17:26:01 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Cj3Is-0007tJ-R8 for emacs-devel@gnu.org; Mon, 27 Dec 2004 17:25:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Cj3Ir-0007sq-TP for emacs-devel@gnu.org; Mon, 27 Dec 2004 17:25:26 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cj3Ir-0007sc-IH for emacs-devel@gnu.org; Mon, 27 Dec 2004 17:25:25 -0500 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cj2xz-0003si-BY for emacs-devel@gnu.org; Mon, 27 Dec 2004 17:03:51 -0500 Original-Received: from zaretski (IGLD-83-130-227-59.inter.net.il [83.130.227.59]) by legolas.inter.net.il (MOS 3.5.5-GR) with ESMTP id DKH80659 (AUTH halo1); Tue, 28 Dec 2004 00:03:30 +0200 (IST) Original-To: Juri Linkov X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 2.2.2 In-reply-to: <87r7lbikl4.fsf@jurta.org> (message from Juri Linkov on Mon, 27 Dec 2004 21:53:43 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31481 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31481 > Cc: bob@rattlesnake.com, emacs-devel@gnu.org > From: Juri Linkov > Date: Mon, 27 Dec 2004 21:53:43 +0200 > > "Eli Zaretskii" writes: > > Please don't use `(type pc)' in face definitions; we now have the > > min-colors feature to express the same color selection in a more > > device-independent way (e.g., it will also be right for a 16-color > > xterm). > > OK. But then `minibuffer-prompt' face whose definition was copied to > `escape-glyph' should be fixed too: No, the minibuffer-prompt face is one of the few cases where the literal `pc' is deliberate. It so happens that many users of the MS-DOS port use blue as their default foreground color. Sorry for not mentioning such exceptions in my original message. > The idea was to make escape-glyph to look like comments I'm not sure that was a good idea, since comments normally have a face that makes them stand out. I thought that several people complained about ^L being too glaring. But I didn't follow the discussion closely, so perhaps I missed the reason for selecting such a color for escape-glyph. > +(defface escape-glyph > + '((((class color) (min-colors 88) (background light)) > + :foreground "dark red") > + (((class color) (min-colors 88) (background dark)) > + :foreground "tan1") > + (((class color) (min-colors 8)) > + :foreground "red")) > + "Face for characters displayed as ^-sequences or \\-sequences." > :group 'basic-faces) This is okay with me, assuming that the consensus is indeed to have escape-glyph stand out in color.