From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-trunk-diffs] Changes to emacs/lisp/faces.el Date: Mon, 27 Dec 2004 10:00:40 +0200 Message-ID: <01c4ebea$Blat.v2.2.2$4d937300@zahav.net.il> References: <87mzwsws3d.fsf@jurta.org> <41B6317B.6020303@esperanto.org> <41BC0D29.9020007@t-online.de> <87sm5wfhh3.fsf@jurta.org> <87ekhcsurb.fsf@jurta.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: deer.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1104134614 20567 80.91.229.6 (27 Dec 2004 08:03:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Dec 2004 08:03:34 +0000 (UTC) Cc: bob@rattlesnake.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 27 09:03:27 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Cipqh-00042A-00 for ; Mon, 27 Dec 2004 09:03:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Ciq1T-0001FP-Vg for ged-emacs-devel@m.gmane.org; Mon, 27 Dec 2004 03:14:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Ciq1M-0001F8-Mz for emacs-devel@gnu.org; Mon, 27 Dec 2004 03:14:28 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Ciq1L-0001Ed-Jd for emacs-devel@gnu.org; Mon, 27 Dec 2004 03:14:28 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Ciq1L-0001E4-BQ for emacs-devel@gnu.org; Mon, 27 Dec 2004 03:14:27 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cippl-0002wn-LV for emacs-devel@gnu.org; Mon, 27 Dec 2004 03:02:29 -0500 Original-Received: from zaretski (IGLD-83-130-227-59.inter.net.il [83.130.227.59]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id ADN85889 (AUTH halo1); Mon, 27 Dec 2004 10:02:12 +0200 (IST) Original-To: Juri Linkov X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 2.2.2 In-reply-to: <87ekhcsurb.fsf@jurta.org> (message from Juri Linkov on Sun, 26 Dec 2004 21:42:36 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31443 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31443 > From: Juri Linkov > Date: Sun, 26 Dec 2004 21:42:36 +0200 > Cc: emacs-devel@gnu.org > > (defface escape-glyph '((((background dark)) :foreground "burlywood2") > (((type pc)) :foreground "magenta") > (t :foreground "dark green")) > "Face for characters displayed as ^-sequences or \\-sequences." > :group 'basic-faces) Please don't use `(type pc)' in face definitions; we now have the min-colors feature to express the same color selection in a more device-independent way (e.g., it will also be right for a 16-color xterm). Also, I think "magenta" is a bad color choice for 16-color terminals, as its definition in tty-colors.el will produce a color that is very different from "burlywood2". How about "brown" or "yellow" instead? The 8-color terminals will also need a separate definition (yellow?): "burlywood2" translates there to "green", believe it or not.