From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: [patch] mode-line faces on 256-color terminals Date: Thu, 23 Dec 2004 06:40:54 +0200 Message-ID: <01c4e8a9$Blat.v2.2.2$bbce6800@zahav.net.il> References: <200412222308.iBMN8rBT002077@scanner2.ics.uci.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: deer.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1103777125 16396 80.91.229.6 (23 Dec 2004 04:45:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 23 Dec 2004 04:45:25 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 23 05:45:16 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ChKqi-00019L-00 for ; Thu, 23 Dec 2004 05:45:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ChL1I-0008SB-4a for ged-emacs-devel@m.gmane.org; Wed, 22 Dec 2004 23:56:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1ChL0g-0008Ri-8h for emacs-devel@gnu.org; Wed, 22 Dec 2004 23:55:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1ChL0e-0008QZ-FD for emacs-devel@gnu.org; Wed, 22 Dec 2004 23:55:32 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ChL0e-0008QW-BI for emacs-devel@gnu.org; Wed, 22 Dec 2004 23:55:32 -0500 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ChKoD-0002Es-M7 for emacs-devel@gnu.org; Wed, 22 Dec 2004 23:42:41 -0500 Original-Received: from zaretski (tony02-27-27.inter.net.il [80.230.27.27]) by legolas.inter.net.il (MOS 3.5.5-GR) with ESMTP id DJW20569 (AUTH halo1); Thu, 23 Dec 2004 06:42:10 +0200 (IST) Original-To: Dan Nicolaescu X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 2.2.2 In-reply-to: <200412222308.iBMN8rBT002077@scanner2.ics.uci.edu> (message from Dan Nicolaescu on Wed, 22 Dec 2004 15:08:50 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31343 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31343 > From: Dan Nicolaescu > Date: Wed, 22 Dec 2004 15:08:50 -0800 > > The mode-line* faces were somehow missed when converting the face > definitions in faces.el to use min-colors, so that they work on > terminals that support 88 (or 256) colors. > > This patch fixes the above issue. Is it OK? It's okay, provided that you checked that this: > (defface mode-line > ! '((((class color) (min-colors 88)) > :box (:line-width -1 :style released-button) > :background "grey75" :foreground "black") doesn't cause any trouble on a tty because of the :box and released-button features it uses.