From: "Eli Zaretskii" <eliz@gnu.org>
Cc: jasonr@gnu.org, emacs-devel@gnu.org
Subject: Re: $USERPROFILE for $HOME on W32
Date: Thu, 25 Nov 2004 23:45:18 +0200 [thread overview]
Message-ID: <01c4d338$Blat.v2.2.2$34177b80@zahav.net.il> (raw)
In-Reply-To: <m18y8p6cwp.fsf-monnier+emacs@gnu.org> (message from Stefan on Thu, 25 Nov 2004 12:45:48 -0500)
> From: Stefan <monnier@iro.umontreal.ca>
> Date: Thu, 25 Nov 2004 12:45:48 -0500
> Cc: emacs-devel@gnu.org, Jason Rumney <jasonr@gnu.org>
>
> >> + /* Set dir and shell from environment variables. */
> >> + strcpy (the_passwd.pw_dir, getenv ("HOME"));
>
> > What if strlen (getenv ("HOME")) >= sizeof (the_passwd.pw_dir)?
>
> Well, tough!
> This code is not new: it's just moved from one place to another so it's not
> a new problem.
Can you (or someone else) look at the w32 system headers and see how
struct passwd is defined there? I looked at two implementations
(DJGPP and glibc on Debian GNU/Linux), and they both define pw_dir and
pw_shell as `char *'. So using strcpy here might mean a disaster, as
no memory could have been allocated for them; I'd use strdup instead.
next prev parent reply other threads:[~2004-11-25 21:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-22 6:26 $USERPROFILE for $HOME on W32 Stefan Monnier
2004-11-22 8:44 ` Jason Rumney
2004-11-22 13:04 ` Stefan Monnier
2004-11-25 16:00 ` Stefan Monnier
2004-11-25 16:34 ` Jason Rumney
2004-11-25 16:54 ` Stefan
2004-11-25 21:52 ` Eli Zaretskii
2004-11-25 22:46 ` Jason Rumney
2004-11-26 10:32 ` Eli Zaretskii
2004-11-25 16:57 ` Andreas Schwab
2004-11-25 17:45 ` Stefan
2004-11-25 17:49 ` Andreas Schwab
2004-11-25 21:45 ` Eli Zaretskii [this message]
2004-11-26 20:56 ` Eli Zaretskii
2004-11-26 23:42 ` Andreas Schwab
2004-11-27 9:33 ` Eli Zaretskii
2004-11-27 13:26 ` Andreas Schwab
2004-11-27 16:40 ` Eli Zaretskii
2004-11-27 17:46 ` Andreas Schwab
2004-11-25 22:04 ` Eli Zaretskii
2004-11-25 23:43 ` Stefan Monnier
2004-11-26 10:29 ` Eli Zaretskii
2004-11-26 14:47 ` Stefan Monnier
2004-11-26 20:50 ` Eli Zaretskii
2004-11-26 22:03 ` Stefan Monnier
2004-11-27 11:36 ` Eli Zaretskii
2004-12-06 23:17 ` Lennart Borgman
2004-11-22 15:46 ` Eli Zaretskii
2004-11-22 16:47 ` Stefan Monnier
2004-11-23 11:49 ` Eli Zaretskii
2004-11-23 8:30 ` Jason Rumney
2004-11-23 11:32 ` Eli Zaretskii
2004-11-23 20:47 ` Jason Rumney
2004-11-23 20:57 ` Eli Zaretskii
2004-11-24 8:17 ` John Paul Wallington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c4d338$Blat.v2.2.2$34177b80@zahav.net.il' \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).