From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Scan of regexps in Emacs (March 17) Date: Sun, 7 Apr 2019 12:06:24 +0200 Message-ID: <01A41B8D-E35A-4665-8ECC-877560F034FF@acm.org> References: <5363970c-3207-1bb4-8b30-74a7d12277cc@cs.ucla.edu> <05269D79-B016-4FCB-94B8-068BF7D1C2D2@acm.org> <3974269b-6cad-0744-bd1f-66c067f94192@cs.ucla.edu> <4b1164c4-e302-ce41-07c3-145d31a97b4c@cs.ucla.edu> <21CCFA3D-B391-44E1-9ED5-1D37009F1988@acm.org> <09AE372B-3A30-4596-8C4E-B9F4CBF6E348@acm.org> <692fe297-1c72-0cda-8765-c119fd0b5ef6@cs.ucla.edu> <8F82F7FF-8921-4ABF-AA1F-18777104BB2A@acm.org> <4aa828be-afda-8606-5606-a5478cf9d306@cs.ucla.edu> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="169874"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 07 12:08:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hD4ik-000i4v-Rz for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2019 12:08:15 +0200 Original-Received: from localhost ([127.0.0.1]:36763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hD4ij-0005cN-He for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2019 06:08:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hD4i7-0005c4-6T for emacs-devel@gnu.org; Sun, 07 Apr 2019 06:07:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hD4i6-00021s-CP for emacs-devel@gnu.org; Sun, 07 Apr 2019 06:07:35 -0400 Original-Received: from mail232c50.megamailservers.eu ([91.136.10.242]:42524 helo=mail37c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hD4i5-0001sM-Mp for emacs-devel@gnu.org; Sun, 07 Apr 2019 06:07:34 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1554631629; bh=2RyR33gQ7AAtO7H8GR/ZCmez8dvJsHOBh1vrzl0dI9I=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=NE3ubMGFY4RgUjkcPE2J/kMxjcrhDNbzxmOPPtXSzFTjnL3c5Kdbz71//c/EB7iwj qs5YlpceoLUI+hLviVTae2SPTfGW1s4tW2JkEVIyf/OeKi1MSbfMqslO7pXPOfdAMA EszDcsE0sMtyJ0PJoO+YlKJpoNr1bzh01PSm/BTo= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x37A6O3J022496; Sun, 7 Apr 2019 10:06:47 +0000 In-Reply-To: <4aa828be-afda-8606-5606-a5478cf9d306@cs.ucla.edu> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020D.5CA9CBCD.001E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=P4AUeBIu c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=bKaaP3oAA9G4Ac42VyYA:9 a=CjuIK1q_8ugA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235065 Archived-At: 7 apr. 2019 kl. 11.47 skrev Paul Eggert : >=20 > Thanks, I installed the attached to fix the oddities that Michael = hadn't already fixed. Looks fine, thank you! Minor detail: - (let* ((sig-re "[a-zA-Z0-9_]*") + (let* ((sig-re "a-zA-Z0-9_") It isn't a regexp; rename to sig-chars maybe? To silence the checker, if nothing else. It latched on to the name, on = the grounds that even if the contents look all right now, someone will = one day believe the name and put a regexp in it.