From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Fri, 11 Mar 2005 17:43:58 +0100 Message-ID: <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> <01c52655$Blat.v2.4$b47b9200@zahav.net.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1110561502 17025 80.91.229.2 (11 Mar 2005 17:18:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2005 17:18:22 +0000 (UTC) Cc: hunterd42@comcast.net, emacs-devel@gnu.org, kobayays@otsukakj.co.jp, jasonr@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 18:18:22 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9niH-0004p8-4y for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 18:14:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9nxO-0000r1-7H for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 12:29:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9nsx-0005Fm-Oq for emacs-devel@gnu.org; Fri, 11 Mar 2005 12:25:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9nsw-0005FW-L1 for emacs-devel@gnu.org; Fri, 11 Mar 2005 12:25:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9nrP-0004Tv-FZ for emacs-devel@gnu.org; Fri, 11 Mar 2005 12:23:39 -0500 Original-Received: from [81.228.11.111] (helo=av5-1-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D9nGA-0006QN-EY; Fri, 11 Mar 2005 11:45:10 -0500 Original-Received: by av5-1-sn1.fre.skanova.net (Postfix, from userid 502) id B903C37E60; Fri, 11 Mar 2005 17:45:09 +0100 (CET) Original-Received: from smtp3-1-sn1.fre.skanova.net (smtp3-1-sn1.fre.skanova.net [81.228.11.163]) by av5-1-sn1.fre.skanova.net (Postfix) with ESMTP id A8AEC37E4D; Fri, 11 Mar 2005 17:45:09 +0100 (CET) Original-Received: from sedrcw11488 (t5o58p129.telia.com [195.67.196.129]) by smtp3-1-sn1.fre.skanova.net (Postfix) with SMTP id A802637E58; Fri, 11 Mar 2005 17:45:07 +0100 (CET) Original-To: "Eli Zaretskii" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34482 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34482 ----- Original Message ----- From: "Eli Zaretskii" > > I think it would be much more readable if we had a special define. > > Not in this case, IMHO; see below. > > > This was my suggestion earlier: > > > > > I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I > > > believe most would like better - but not I) replacing them with something > > > like > > > > > > #ifdef HAS_HOURGLASS > > > > In the light of your answers I do not believe you want to remove these > > ifdefs so I suggest now we do something like: > > > > #if HAVE_HOURGLASS > > This would require to have some configury stuff that would detect > whether HAVE_HOURGLASS should be defined or not. Since Windows > doesn't run the usual configure script (and neither does the DOS > port), adding such a define will require more hacking in these ports. > Especially since writing a test for this feature is not so easy even > for those platforms which do support hourglass (e.g., think about > Emacs configured with --without-x). > > So please don't do that. Please replace > > #ifdef HAVE_X_WINDOWS > > with > > #if defined(HAVE_X_WINDOWS) || defined(HAVE_NTGUI) There is a lot of them. I understand your concern. However we do not have to do anything difficult to use HAVE_HOURGLASS. After taking a look at the code I believe HAVE_HOURGLASS should go into src\config.in. There is already an #ifdef HAVE_X_WINDOWS and I suggest putting something like this after that define: /* This is for the hourglass code in various files. */ #if defined(HAVE_X_WINDOWS) || defined(HAVE_NTGUI) #define HAVE_HOURGLASS #endif IMO it will be more readable and if you want to add hourglass code for other systems some day it is easier.