From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 82ccc3a: ; Mention the previous change in NEWS Date: Tue, 8 Jun 2021 18:21:19 +0300 Message-ID: <00d9453e-7f49-7f50-7017-6a518b3086ed@yandex.ru> References: <83lf7lfwc8.fsf@gnu.org> <835yyoft5k.fsf@gnu.org> <83tum8e6xb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6872"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 08 17:22:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqdYV-0001Ss-Vf for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Jun 2021 17:22:15 +0200 Original-Received: from localhost ([::1]:52970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqdYU-0001ST-2T for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Jun 2021 11:22:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqdXl-0000lB-48 for emacs-devel@gnu.org; Tue, 08 Jun 2021 11:21:29 -0400 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:37797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqdXj-0001ww-9l; Tue, 08 Jun 2021 11:21:28 -0400 Original-Received: by mail-wm1-x32f.google.com with SMTP id f16-20020a05600c1550b02901b00c1be4abso2239860wmg.2; Tue, 08 Jun 2021 08:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8R0UPz4Oe9ArdRZsGSXF5jPgKAWOQeD8GUZtGW6hQhQ=; b=R91B4Uzv4LhIe+V134U9J2mKPY5pRqElxVUPOJ2V6N1QNoyi6CE4QPyaj4m9SXh5/E kE8pTKnXd6vWZ5w85BIVvlyuB1DxVHJblftj25Z19NOluomcItll8fJpqS0zPguUN5ap KpwPitPTArLkF26PaNji30wTHe3cNvBtEpX3uQLoADw900unjamyCDsKJ3aybao3nHmb QBk+UKhfjiSamTo0y2iFEhulrXQEgAORftv8fEsOsSqUhqTh01iDB4DXgzm8Wn/AsF4X yklCooKRmnlXMak7tbv7PoAYfswYIbXP3ehwtkYCweKmVa/v79SOUNAxwpSDpa0HZ7Rd 0naQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8R0UPz4Oe9ArdRZsGSXF5jPgKAWOQeD8GUZtGW6hQhQ=; b=cXLNa0HavfW+JhkK9etO/LZafegA8JQaRtYjhagM+9N3ZUwnMcsXyveiFaoFRT5Gbw 2l14FZKNR8Z7zmsEoK7oGJSTgbtwovTOiWdOWMkBS6ySAFpj2Ou6qINdMr4Ix5E1Sfdo oj2hCmopaFbrj4DL/r9jdTIGwYvIA/2mAm41YHsdHdd36go+DlrbeVlLeuje1aMcPE81 JNTOcWlyIId5DD9GyJ0PA8wkuhb0rQFf040EnACrcSbe/6J/czuuYax2PXvaREO+yl1X ttNZaV4bUJg1UAc7wohtAcXxVJ2i8OgKA3w0zaynUgrp+aTQl6QAqCRZJbLFj34inY/k aegQ== X-Gm-Message-State: AOAM532YxSV2bmW0wkUCTGzLstafeM7eHcdLWrgo4MWCWJNMaqjjgBkN 0IWz5MFn36tb8PdtwBQE/u2uNOzRt/o= X-Google-Smtp-Source: ABdhPJxp+e5R84BEdzY6tPskfIwg6LU3DZLrSLgs3KIspURMYQKlIQEqBuMRVKauGdKK7yLgBQPSqQ== X-Received: by 2002:a05:600c:354d:: with SMTP id i13mr2612938wmq.67.1623165682062; Tue, 08 Jun 2021 08:21:22 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l13sm19495091wrv.57.2021.06.08.08.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 08:21:20 -0700 (PDT) In-Reply-To: <83tum8e6xb.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270566 Archived-At: On 08.06.2021 18:02, Eli Zaretskii wrote: >>>> rgrep, which also has some ignores to handle, uses "." as the DIR >>>> argument, so it should see no change. >>> >>> That's just the default, right? >> >> No, that's what it does: it passes for directory to search in through >> the value of default-directory. The argument to 'find' is always ".". > > Not sure I follow: the user could customize grep-find-template to put > a specific directory instead of , right? I'm talking about what the 'rgrep' command does. As well as its variants like zrgrep. Customizing grep-find-template to include a specific directory sounds stupid: that would break rgrep and other commands that use it. So I probably don't understand what you meant. >>>> xref-matches-in-directory has no known callers anymore, but any >>>> third-party code should see the IGNORES honored better with those old >>>> versions of 'find'. >>> >>> So we could say that any command which uses xref-matches-in-directory >>> is affected. >> >> Is that better than saying that the variable changed? Possibly affecting >> any code that uses it is an obvious implication. > > How about saying both? No objection from me. >> We can say that about xref-matches-in-directory, noting that the change >> is likely to only be noticeable with old versions of 'find'. > > That'd be good, yes. > >> Which apparently includes macOS systems, but I'm not sure which >> ones, and whether using "Homebrew" or not matters for this case. > > Maybe also some *BSD? We could mention macOS, or we could say > something like "non-GNU Find". Some -- maybe. But I tried one or two recent FreeBSD releases in a VM, and they didn't have that problem.