From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Fri, 11 Mar 2005 00:33:16 +0100 Message-ID: <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1110498303 24302 80.91.229.2 (10 Mar 2005 23:45:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 10 Mar 2005 23:45:03 +0000 (UTC) Cc: rms@gnu.org, Jason Rumney , David Hunter , KOBAYASHI Yasuhiro , Eli Zaretskii , "Jan D." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 00:45:02 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9XCJ-0001OQ-Hu for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 00:36:08 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9XRH-0005HX-9A for ged-emacs-devel@m.gmane.org; Thu, 10 Mar 2005 18:51:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9XQ8-0004Au-IE for emacs-devel@gnu.org; Thu, 10 Mar 2005 18:50:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9XQ0-00046U-L1 for emacs-devel@gnu.org; Thu, 10 Mar 2005 18:50:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9XPz-00041s-Q7 for emacs-devel@gnu.org; Thu, 10 Mar 2005 18:50:15 -0500 Original-Received: from [81.228.11.107] (helo=av1-1-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D9XAV-0000SQ-Jv; Thu, 10 Mar 2005 18:34:16 -0500 Original-Received: by av1-1-sn1.fre.skanova.net (Postfix, from userid 502) id A752637E55; Fri, 11 Mar 2005 00:34:14 +0100 (CET) Original-Received: from smtp3-1-sn1.fre.skanova.net (smtp3-1-sn1.fre.skanova.net [81.228.11.163]) by av1-1-sn1.fre.skanova.net (Postfix) with ESMTP id 9858737E44; Fri, 11 Mar 2005 00:34:14 +0100 (CET) Original-Received: from sedrcw11488 (t4o58p188.telia.com [195.252.57.188]) by smtp3-1-sn1.fre.skanova.net (Postfix) with SMTP id 4279137E49; Fri, 11 Mar 2005 00:34:11 +0100 (CET) Original-To: X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34442 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34442 ----- Original Message ----- From: "Lennart Borgman" > ----- Original Message ----- > From: "Eli Zaretskii" > > > I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I > > > believe most would like better - but not I) replacing them with > something > > > like > > > > > > #ifdef HAS_HOURGLASS > > > > We cannot do the former without adding (possibly empty) functions > > called by those snippets to all ports. And we cannot do the latter > > without adding some configury stuff that would determine the value of > > HAS_HOURGLASS at configure time. > > > > Personally, I think we are fine as we are now. Of course, if you > > implement start_hourglass et al for Windows, the HAVE_X_WINDOWS > > condition needs to be augmented by something that will enable it for > > Windows. > > Yes, I thought I would implement start_hourglass etc. Maybe someone wants > to implement it in macfns.c too where the body part also has an empty body > part. > > Whichever way of changing the current "#ifdef HAVE_X_WINDOWS" at those > places are enough, but removing the ifdef:s and adding a file with empty > body parts for those ports that does not implement hourglass support makes > the code easier to read IMO. I have implemented code for hourglass on w32 now (or rather I should say Dave Hunter has done it, I just did a small amount of typing). Could we please get a decision on the issue above so that it is possible to get this working with the CVS code? (The hourglass code in keyboard.c is currently only called if HAVE_X_WINDOWS is defined.)