From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: compilation-next-error - extra `let' binding? Date: Fri, 8 Feb 2008 10:41:29 -0800 Message-ID: <005c01c86a82$3803b940$a350908d@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1202496138 29302 80.91.229.12 (8 Feb 2008 18:42:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Feb 2008 18:42:18 +0000 (UTC) To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 19:42:40 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JNYBJ-0002gY-5F for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2008 19:42:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JNYAq-0003MS-EJ for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2008 13:42:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JNYAm-0003MN-Jo for emacs-devel@gnu.org; Fri, 08 Feb 2008 13:42:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JNYAk-0003MB-7m for emacs-devel@gnu.org; Fri, 08 Feb 2008 13:42:03 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JNYAk-0003M8-45 for emacs-devel@gnu.org; Fri, 08 Feb 2008 13:42:02 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JNYAk-00014K-2V for emacs-devel@gnu.org; Fri, 08 Feb 2008 13:42:02 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JNYAj-00068h-Hh for emacs-pretest-bug@gnu.org; Fri, 08 Feb 2008 13:42:01 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JNYAg-00013F-Fe for emacs-pretest-bug@gnu.org; Fri, 08 Feb 2008 13:42:01 -0500 Original-Received: from agminet01.oracle.com ([141.146.126.228]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JNYAg-00012v-2i for emacs-pretest-bug@gnu.org; Fri, 08 Feb 2008 13:41:58 -0500 Original-Received: from agmgw2.us.oracle.com (agmgw2.us.oracle.com [152.68.180.213]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id m18IftGK031833 for ; Fri, 8 Feb 2008 12:41:55 -0600 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by agmgw2.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id m189Sk6m028024 for ; Fri, 8 Feb 2008 11:41:54 -0700 Original-Received: from inet-141-146-46-1.oracle.com by acsmt351.oracle.com with ESMTP id 3565371031202496084; Fri, 08 Feb 2008 10:41:24 -0800 Original-Received: from dradamslap1 (/141.144.80.163) by bhmail.oracle.com (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 08 Feb 2008 10:41:23 -0800 X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 Thread-Index: AchqgjeWwxqCfpu8QjOC0vx5fyXvAA== X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:88537 gmane.emacs.pretest.bugs:20956 Archived-At: Can't tell for sure without checking all of the code called by the body of the `let', but it looks like the `let' binding of `loc' in `compilation-next-error' is superfluous: (let* ((msg (get-text-property pt 'message)) (loc (car msg)) ; ??????? last) If so, taking out the binding would make the code easier to understand. If not, adding a comment for it might make the code easier to understand. In GNU Emacs 22.1.90.1 (i386-mingw-nt5.1.2600) of 2008-01-30 on PRETEST Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'