From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: compilation-next-error - extra `let' binding?
Date: Fri, 8 Feb 2008 10:41:29 -0800 [thread overview]
Message-ID: <005c01c86a82$3803b940$a350908d@us.oracle.com> (raw)
Can't tell for sure without checking all of the code called by the
body of the `let', but it looks like the `let' binding of `loc' in
`compilation-next-error' is superfluous:
(let* ((msg (get-text-property pt 'message))
(loc (car msg)) ; ???????
last)
If so, taking out the binding would make the code easier to
understand. If not, adding a comment for it might make the code easier
to understand.
In GNU Emacs 22.1.90.1 (i386-mingw-nt5.1.2600)
of 2008-01-30 on PRETEST
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'
next reply other threads:[~2008-02-08 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 18:41 Drew Adams [this message]
2008-02-08 18:49 ` compilation-next-error - extra `let' binding? Drew Adams
2008-02-10 3:17 ` Stefan Monnier
2008-02-10 3:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005c01c86a82$3803b940$a350908d@us.oracle.com' \
--to=drew.adams@oracle.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).