From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Poll: Change xref-show-definitions-function's default? Date: Sat, 9 Jan 2021 02:35:57 +0200 Message-ID: <00496fed-5904-28c7-c2b4-410cfc2a708e@yandex.ru> References: <9af40a30-8964-3142-aadf-6592605720ec@yandex.ru> <871rf0ob2c.fsf@mail.linkov.net> <7b108ef2-7798-19b9-f37d-680bdcb23745@yandex.ru> <87czyh52rj.fsf@mail.linkov.net> <07c6166d-119a-6479-03ed-2bde5c51959f@yandex.ru> <87h7nsslqk.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39227"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 09 01:37:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ky2Fe-000A7I-32 for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Jan 2021 01:37:06 +0100 Original-Received: from localhost ([::1]:54528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ky2Fc-0001gX-Us for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jan 2021 19:37:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ky2Eh-0001Ez-Kw for emacs-devel@gnu.org; Fri, 08 Jan 2021 19:36:07 -0500 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:50954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ky2Ef-000548-Lt for emacs-devel@gnu.org; Fri, 08 Jan 2021 19:36:07 -0500 Original-Received: by mail-wm1-x335.google.com with SMTP id 190so9131149wmz.0 for ; Fri, 08 Jan 2021 16:36:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=r56PqzGdyghWGqevkbUxFdKs1Du2D8DwAP/KTzLWgs0=; b=NTVyijjKqOKDGtQ88Fd5uqRaW6yEAI83lX9JtdKW9Pl09nUPt8OchM8qQTf1cCMaQU l3SV85rI9uuCjaUDT9uQeyVvYYpsjcueig6Oo5eZpZhWE0AwqCtGDA8pOGSFVdAqiJVZ mX/A00J6Bb22uGAOKYgP49yh1GAJas8EH8DGVzPgTfdUQukFs2wARX3rE0bOwQVgMGH8 SRy0Q/omRkFxmybrZJB2ELFccbc07TKq3CjAoiYQ+ZNCgfnx8RGweLXZfWaAPcJqdbZR 30pmsMN7Mw08tbDex6AAXExgg+fQn3jwOCcCY0D4sAmjBpjofVmcWUtUwsEarpFONc1U oTqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r56PqzGdyghWGqevkbUxFdKs1Du2D8DwAP/KTzLWgs0=; b=TwjQnT/j2qQrRAbW3gx+Y6v+bt1/TkKRQDtgYQ3hx413PSkE1DI+yX4jsyDAB63afn zMbAdD2qfULMdY2v1oJb2U85v/ejkZefHN0r0cFDrRlEIjx1QdbzTwN7SWNZ/2VNHbPV eEHkEMMH35Wl35Ljl7c5QhVSsQRoe0qbqFiqe/g4OshceTULx7SRgC0yYN9h/hyWGtqg 3f1GrfnE/wdC72P4Fit2GfUmIAgbWqdhor//Mg/3X78iRRwYz97hn60kH/g9EX6RiKbt RFswjtuDySTesjsJrnAjhTGnNLj1CxaVhGpcfc5tSzj+7cbcM3DPiXSyWRbtR4eoevns CTbA== X-Gm-Message-State: AOAM530Om/fCQcHVjdm7zuxT45UQa96AVli2Le/h613nkCWCiKb9+++B MGeUkObyVhxuAR2BnS8jiHkoJr8CmBX9MA== X-Google-Smtp-Source: ABdhPJyFMX27jwv4ygmhIa592Flf1uK4d1fFTuacxnirlKEAq5uKM+Szr1SwUtQ88uo2TGclUbfz/w== X-Received: by 2002:a7b:cb09:: with SMTP id u9mr5283485wmj.61.1610152563447; Fri, 08 Jan 2021 16:36:03 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c7sm16810304wro.16.2021.01.08.16.36.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jan 2021 16:36:02 -0800 (PST) In-Reply-To: <87h7nsslqk.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=raaahh@gmail.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.241, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262778 Archived-At: On 07.01.2021 19:47, Juri Linkov wrote: >>> I'm afraid the default of xref-show-definitions-function can't be changed >>> to xref-show-definitions-completing-read because as this poll indicates >>> it works satisfactorily only in combination with icomplete-mode and >>> also non-nil icomplete-show-matches-on-no-input. >> >> What about xref-show-definitions-buffer-at-bottom, then? > > Sorry, I have no opinion about xref-show-definitions-buffer-at-bottom, > I'm using xref-show-definitions-completing-read with icomplete. It's all right. But at the moment, very few users have expressed their preference one way or another, which doesn't give me much to work with. Guess we can try out the strategy discussed in another thread: announce the "temporary" switch in the default and collect the impressions a few weeks later. >>>> Then we can safely remove/change the TAB binding in xref--xref-buffer-mode, >>>> or alternatively, create a new major mode that is slightly more Grep-like, >>>> and use it in the default xref-show-xrefs-function. >>> Maybe a new submode could help to resolve this discrepancy. >> >> Yes, that's the second option I meant. > > Maybe the TAB keybinding should depend on the value of > xref-show-definitions-function. When it is customized to > xref-show-definitions-completing-read then don't bind TAB. Aside from an effect like that being non-obvious, I'm afraid that can't help most of our users, who will likely stay on the default. Someone who changes their xref-show-definitions-function might as well change the bindings too, right? It's only a few lines in the init script. It will also fail to help users who customize their xref-show-definitions-function to some other value (e.g. based on Ivy or Helm). But if the change in the default fails, we'll go back and consider other options from bug#44611's discussion.