From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: emacs-devel@gnu.org
Subject: RE: `emacs -nw', `framep' returning `t', `display-graphic-p' returning `nil'
Date: Sun, 17 Dec 2017 14:26:25 -0800 (PST) [thread overview]
Message-ID: <0045d89b-1bfe-45e8-897e-d33a4111bfad@default> (raw)
In-Reply-To: <<836095qmvk.fsf@gnu.org>>
> a single Emacs session can have both text-mode and GUI
> frames.
I see. Learn something new everyday.
I use `display-graphic-p' in many places to guard some code
that might try to use graphic-display capabilities.
Apparently some of those uses might not really be appropriate
(might not do what I was expecting). Thanks for the info.
> So I think you should examine the value of display-graphic-p
> not at key-binding time, but inside diredp-chown-this-file, because
> only then you know on which kind of frame will the command run.
No, that would be pretty useless. It wouldn't even make sense
to test it in a Dired mode hook (readin or whatever), as the same
Dired buffer could be shown either or both of the two types of
frame.
I'll just remove the `display-graphic-p' test and leave only
the user option as the test.
next parent reply other threads:[~2017-12-17 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<a508c72a-05ba-4b83-a687-5e7b4134821f@default>
[not found] ` <<836095qmvk.fsf@gnu.org>
2017-12-17 22:26 ` Drew Adams [this message]
2017-12-17 17:10 `emacs -nw', `framep' returning `t', `display-graphic-p' returning `nil' Drew Adams
2017-12-17 17:34 ` Eli Zaretskii
2017-12-17 18:02 ` Achim Gratz
2017-12-17 20:10 ` Eli Zaretskii
2017-12-17 21:06 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0045d89b-1bfe-45e8-897e-d33a4111bfad@default \
--to=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).