Suggested change to man/makefile.w32-in

Suggested change to man/makefile.w32-in

[Lennart Borgman]

There were one more problem with building info on w32 which I did not notice
first. It will currently only build when cmd.exe is the shell.

To get "make info" to work when MSYS is in the path (which makes "sh" the
shell for the makefile) the following change should be made to
"man/makefile.w32-in":

****Old:
info: $(INFO_TARGETS)
ifeq "$(SHELLTYPE)" "CMD"
 $(MULTI_INSTALL_INFO) --info-dir=$(infodir) $(INFO_TARGETS)

****New:
info: $(INFO_TARGETS)
ifeq "$(SHELLTYPE)" "CMD"
 $(MULTI_INSTALL_INFO) --info-dir=$(infodir) $(INFO_TARGETS)
else
 for file in $(INFO_TARGETS); do install-info --info-dir=$(infodir)
$${file}; done
endif

After this change (and with makeinfo from MSYS replaced with makeinfo from
http://gnuwin32.sourceforge.net/) "make info" will build ok.

Could this change be accepted? (I have not checked in any change.)


- Lennart

Re: Suggested change to man/makefile.w32-in

[Jason Rumney]

"Lennart Borgman" <lennart.borgman.073@student.lu.se> writes:

> There were one more problem with building info on w32 which I did not notice
> first. It will currently only build when cmd.exe is the shell.
>
> To get "make info" to work when MSYS is in the path (which makes "sh" the
> shell for the makefile) the following change should be made to
> "man/makefile.w32-in":
>
> ****Old:
> info: $(INFO_TARGETS)
> ifeq "$(SHELLTYPE)" "CMD"
>  $(MULTI_INSTALL_INFO) --info-dir=$(infodir) $(INFO_TARGETS)

In the version I have, that line is unconditional. I am pretty sure
that using ifeq will break the build in nmake anyway.

Is there still a problem with msys if you remove the ifeq line above?

Re: Suggested change to man/makefile.w32-in

[Lennart Borgman]

----- Original Message ----- 
From: "Jason Rumney" <jasonr@gnu.org>
To: "Lennart Borgman" <lennart.borgman.073@student.lu.se>
Cc: "Emacs Devel" <emacs-devel@gnu.org>
Sent: Sunday, October 24, 2004 10:50 PM
Subject: Re: Suggested change to man/makefile.w32-in


: "Lennart Borgman" <lennart.borgman.073@student.lu.se> writes:
:
: > There were one more problem with building info on w32 which I did not
notice
: > first. It will currently only build when cmd.exe is the shell.
: >
: > To get "make info" to work when MSYS is in the path (which makes "sh"
the
: > shell for the makefile) the following change should be made to
: > "man/makefile.w32-in":
: >
: > ****Old:
: > info: $(INFO_TARGETS)
: > ifeq "$(SHELLTYPE)" "CMD"
: >  $(MULTI_INSTALL_INFO) --info-dir=$(infodir) $(INFO_TARGETS)
:
: In the version I have, that line is unconditional. I am pretty sure
: that using ifeq will break the build in nmake anyway.

It is a typo by me, there is no ifeq line in the old version.

Could the ifeq line in the new version be written in a way that handles both
nmake and gmake?


: Is there still a problem with msys if you remove the ifeq line above?

Yes, multi-install-info.bat is treated as a sh script by MSYS (and that does
not work very well).


- Lennart

Re: Suggested change to man/makefile.w32-in

[Jason Rumney]

"Lennart Borgman" <lennart.borgman.073@student.lu.se> writes:

> : Is there still a problem with msys if you remove the ifeq line above?
>
> Yes, multi-install-info.bat is treated as a sh script by MSYS (and that does
> not work very well).

Then it is msys sh that is broken. Even Cygwin bash knows how to run
Windows BAT files.

I think there is already a note in nt/INSTALL that you may need to run
make as "make SHELL=cmd.exe", so I don't think we need to to
anything. I don't want to put lots of conditionals in the makefile to
cope with all the broken ports of Posix shells that have ever been
ported to Windows.

Re: Suggested change to man/makefile.w32-in

[Kim F. Storm]

Jason Rumney <jasonr@gnu.org> writes:

> I don't want to put lots of conditionals in the makefile to
> cope with all the broken ports of Posix shells that have ever been
> ported to Windows.

Right.

And once we have a final release, most windoze users will download a
binary distribution anyway, so we shouldn't spend a lot of time on the
issue of refining the build process on windoze.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Suggested change to man/makefile.w32-in

[Lennart Borgman]

----- Original Message ----- 
From: "Kim F. Storm" <storm@cua.dk>

: > I don't want to put lots of conditionals in the makefile to
: > cope with all the broken ports of Posix shells that have ever been
: > ported to Windows.
:
: Right.
:
: And once we have a final release, most windoze users will download a
: binary distribution anyway, so we shouldn't spend a lot of time on the
: issue of refining the build process on windoze.

Maybe not a lot of time, but it is essential that the build process is easy
on ms windows. This way more errors will be captured early.

I will try to bring this issues to the MSYS mailing list.

- Lennart

Re: Suggested change to man/makefile.w32-in

[Lennart Borgman]

----- Original Message ----- 
From: "Jason Rumney" <jasonr@gnu.org>

: Then it is msys sh that is broken. Even Cygwin bash knows how to run
: Windows BAT files.

I have told this on the ming-msys mailing list.

: I think there is already a note in nt/INSTALL that you may need to run
: make as "make SHELL=cmd.exe", so I don't think we need to to
: anything. I don't want to put lots of conditionals in the makefile to
: cope with all the broken ports of Posix shells that have ever been
: ported to Windows.

There is no such note in nt/INSTALL as far as I can see. I do not think I
have seen this note anywhere. It might be one of the reasons that so many
seem to complain it is difficult to build Emacs on ms windows.

If it really works using make SHELL=cmd.exe then maybe there should be a
notion in nt/INSTALL?


- Lennart

Re: Suggested change to man/makefile.w32-in

[Jason Rumney]

"Lennart Borgman" <lennart.borgman.073@student.lu.se> writes:

> : I think there is already a note in nt/INSTALL that you may need to run
> : make as "make SHELL=cmd.exe"
>
> There is no such note in nt/INSTALL as far as I can see.

No I misremembered, it is in etc/PROBLEMS and is for different
symptoms than this one.

> If it really works using make SHELL=cmd.exe then maybe there should be a
> notion in nt/INSTALL?

I will add a note there as well.

Re: Suggested change to man/makefile.w32-in

[Lennart Borgman]

----- Original Message ----- 
From: "Jason Rumney" <jasonr@gnu.org>

: > If it really works using make SHELL=cmd.exe then maybe there should be a
: > notion in nt/INSTALL?
:
: I will add a note there as well.

It still fails if MSYS sh.exe is in the path. This seems to be a problem
with the makefile as far as I understand. Maybe this should be noted until
MSYS is fixed? (I believe it would be good if MSYS in the future could be
used the same way as Cygwin for building Emacs.

- Lennart