From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: Should shell-quote-argument really use (eq system-type 'windows-nt)? Date: Mon, 7 Mar 2005 14:53:31 +0100 Message-ID: <003301c5231d$9c2f3390$0200a8c0@sedrcw11488> References: <47393.217.194.34.123.1110200368.squirrel@wwws.franken.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1110204141 8755 80.91.229.2 (7 Mar 2005 14:02:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2005 14:02:21 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 07 15:02:21 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D8ImX-00054U-9Y for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2005 15:00:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D8J6I-00035K-Nj for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2005 09:20:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D8J5m-0002zD-NR for emacs-devel@gnu.org; Mon, 07 Mar 2005 09:20:18 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D8J5g-0002wL-Hl for emacs-devel@gnu.org; Mon, 07 Mar 2005 09:20:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D8J5f-0002tc-NE for emacs-devel@gnu.org; Mon, 07 Mar 2005 09:20:11 -0500 Original-Received: from [81.228.10.115] (helo=av1-2-sn4.m-sp.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D8Ijy-0001P4-CS for emacs-devel@gnu.org; Mon, 07 Mar 2005 08:57:46 -0500 Original-Received: by av1-2-sn4.m-sp.skanova.net (Postfix, from userid 502) id 8859737E93; Mon, 7 Mar 2005 14:57:44 +0100 (CET) Original-Received: from smtp2-2-sn4.m-sp.skanova.net (smtp2-2-sn4.m-sp.skanova.net [81.228.10.182]) by av1-2-sn4.m-sp.skanova.net (Postfix) with ESMTP id 7851437E90; Mon, 7 Mar 2005 14:57:44 +0100 (CET) Original-Received: from sedrcw11488 (t5o58p111.telia.com [195.67.196.111]) by smtp2-2-sn4.m-sp.skanova.net (Postfix) with SMTP id 7B8D937E4B; Mon, 7 Mar 2005 14:57:43 +0100 (CET) Original-To: "Stephan Stahl" , X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34274 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34274 ----- Original Message ----- From: "Stephan Stahl" > I think shell-quote-argument should not use > (eq system-type'windows-nt) > instead it should take shell-file-name into account. > > It seems very usual for emacs users on w32 to use cygwin or mingw. > Right now shell-quote-argument would return something wrong when bash > or some "intelligent" shell is used on w32 because it assumes a dumb > w32 shell. > > What do others think about this (little tested) change? I have not tested your change but I think your idea is good.