From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Tue, 1 Mar 2005 01:17:04 +0100 Message-ID: <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1109637569 30850 80.91.229.2 (1 Mar 2005 00:39:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 1 Mar 2005 00:39:29 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 01 01:39:28 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D5vPB-00044C-D3 for ged-emacs-devel@m.gmane.org; Tue, 01 Mar 2005 01:38:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D5vhd-0002kc-C5 for ged-emacs-devel@m.gmane.org; Mon, 28 Feb 2005 19:57:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D5vdg-0000hv-5r for emacs-devel@gnu.org; Mon, 28 Feb 2005 19:53:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D5vda-0000dL-2L for emacs-devel@gnu.org; Mon, 28 Feb 2005 19:53:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D5vdV-0000Qi-WD for emacs-devel@gnu.org; Mon, 28 Feb 2005 19:53:19 -0500 Original-Received: from [81.228.9.107] (helo=av2-1-sn3.vrr.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D5v50-0000Gq-F3; Mon, 28 Feb 2005 19:17:38 -0500 Original-Received: by av2-1-sn3.vrr.skanova.net (Postfix, from userid 502) id BCB3F3814C; Tue, 1 Mar 2005 01:17:37 +0100 (CET) Original-Received: from smtp1-2-sn3.vrr.skanova.net (smtp1-2-sn3.vrr.skanova.net [81.228.9.178]) by av2-1-sn3.vrr.skanova.net (Postfix) with ESMTP id AE4393814B; Tue, 1 Mar 2005 01:17:37 +0100 (CET) Original-Received: from sedrcw11488 (t1o58p124.telia.com [62.20.164.124]) by smtp1-2-sn3.vrr.skanova.net (Postfix) with SMTP id AE8C738007; Tue, 1 Mar 2005 01:17:36 +0100 (CET) Original-To: "Eli Zaretskii" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:33959 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:33959 ----- Original Message ----- From: "Eli Zaretskii" > > From: "Lennart Borgman" > > I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I > > believe most would like better - but not I) replacing them with something > > like > > > > #ifdef HAS_HOURGLASS > > We cannot do the former without adding (possibly empty) functions > called by those snippets to all ports. And we cannot do the latter > without adding some configury stuff that would determine the value of > HAS_HOURGLASS at configure time. > > Personally, I think we are fine as we are now. Of course, if you > implement start_hourglass et al for Windows, the HAVE_X_WINDOWS > condition needs to be augmented by something that will enable it for > Windows. Yes, I thought I would implement start_hourglass etc. Maybe someone wants to implement it in macfns.c too where the body part also has an empty body part. Whichever way of changing the current "#ifdef HAVE_X_WINDOWS" at those places are enough, but removing the ifdef:s and adding a file with empty body parts for those ports that does not implement hourglass support makes the code easier to read IMO.