From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: face-remapping-alist client code Date: Mon, 2 Jun 2008 08:56:22 -0700 Message-ID: <001701c8c4c9$34db5880$c2b22382@us.oracle.com> References: <611w3gcesf.fsf@fencepost.gnu.org><005201c8c4bb$aec2f580$0200a8c0@us.oracle.com> <87tzgbzyjq.fsf@catnip.gol.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1212422328 8532 80.91.229.12 (2 Jun 2008 15:58:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Jun 2008 15:58:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: "'Miles Bader'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 02 17:59:29 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K3CRI-0002Lt-E3 for ged-emacs-devel@m.gmane.org; Mon, 02 Jun 2008 17:59:16 +0200 Original-Received: from localhost ([127.0.0.1]:53149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3CQW-0006WE-Cl for ged-emacs-devel@m.gmane.org; Mon, 02 Jun 2008 11:58:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3CQQ-0006TA-HC for emacs-devel@gnu.org; Mon, 02 Jun 2008 11:58:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3CQO-0006Q8-Uy for emacs-devel@gnu.org; Mon, 02 Jun 2008 11:58:22 -0400 Original-Received: from [199.232.76.173] (port=46850 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3CQO-0006Pi-Pi for emacs-devel@gnu.org; Mon, 02 Jun 2008 11:58:20 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]:51547) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K3CQG-0005er-Bl; Mon, 02 Jun 2008 11:58:12 -0400 Original-Received: from agmgw1.us.oracle.com (agmgw1.us.oracle.com [152.68.180.212]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id m52Fw5dn003868; Mon, 2 Jun 2008 09:58:05 -0600 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by agmgw1.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id m529BqjH010518; Mon, 2 Jun 2008 09:58:04 -0600 Original-Received: from inet-141-146-46-1.oracle.com by acsmt350.oracle.com with ESMTP id 3685847541212422183; Mon, 02 Jun 2008 08:56:23 -0700 Original-Received: from dradamslap1 (/130.35.178.194) by bhmail.oracle.com (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 02 Jun 2008 08:56:23 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87tzgbzyjq.fsf@catnip.gol.com> Thread-Index: AcjEv1jwO0DkJSUFTlCq4l72Hm3b+QABsxCg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98241 Archived-At: > > I'm not crazy about binding keys for this (just by > > loading), and those key bindings in particular. > > It's OK to suggest bindings in the Commentary, however. > > That kind of thing will be cleaned up before committing (I'm not > entirely sure how one goes about adding default bindings). > [I think the C-+/C-= and C-- bindings are correct however, as they are > what people expect.] They might be what some people outside Emacs expect for font resizing, but I would still prefer that the library not create any bindings. Except possibly via a minor-mode map. Also, `C--' is useful for its `negative-argument' binding (even if there are alternatives). Wrt `C-=', my personal preference would be to reserve that as a prefix key for comparisons of different types. I use these, for instance: C-= b ediff-buffers C-= d diff C-= e ediff-files C-= f ediff-files C-= w compare-windows > The current code operates _per buffer_ (the previous code > grew or shrunk the entire frame). I think per-buffer operation > is far more useful (e.g., I currently have my Gnus article buffer > resized up one step which is kind of pleasant; for viewing big > files, resizing down a step or two is quite nice). That is a definite advantage over the approach I use. > The size calculations I'm using are the same as before -- a simple > constant factor height scaling for each step -- and probably will > occasionally miss a step on platforms with only non-scalable fonts and > poor font size coverage. With scalable fonts, however, this simple > calculation works very well. > > [Another issue with per-frame size changing was that very frequent > changing of the default frame face tended to crash Emacs. The whole > baroque mechanism that gets invoked for that case is complicated and > fragile.] I don't see that, but perhaps it is platform-related. I'm using Windows. AFAICT, it works fine and fast in Emacs 20 through 23. > Another point is that the per-buffer mechanism is much faster > (even on a slow machine) -- frame-resize is _slow_ as well as being > flaky. You can happily use auto-repeat... :-) I don't see any slowdown either, but perhaps that too is platform-related. FWIW, I use auto-repeat with frame-resizing all of the time. I use it not only to zoom (via font) but also to change frame width and height.