unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Miles Bader'" <miles@gnu.org>
Cc: emacs-devel@gnu.org
Subject: RE: face-remapping-alist client code
Date: Mon, 2 Jun 2008 08:56:22 -0700	[thread overview]
Message-ID: <001701c8c4c9$34db5880$c2b22382@us.oracle.com> (raw)
In-Reply-To: <87tzgbzyjq.fsf@catnip.gol.com>

> > I'm not crazy about binding keys for this (just by 
> > loading), and those key bindings in particular.
> > It's OK to suggest bindings in the Commentary, however.
> 
> That kind of thing will be cleaned up before committing (I'm not
> entirely sure how one goes about adding default bindings).
> [I think the C-+/C-= and C-- bindings are correct however, as they are
> what people expect.]

They might be what some people outside Emacs expect for font resizing, but I
would still prefer that the library not create any bindings. Except possibly via
a minor-mode map.

Also, `C--' is useful for its `negative-argument' binding (even if there are
alternatives).

Wrt `C-=', my personal preference would be to reserve that as a prefix key for
comparisons of different types. I use these, for instance:

 C-= b  ediff-buffers
 C-= d  diff
 C-= e  ediff-files
 C-= f  ediff-files
 C-= w  compare-windows

> The current code operates _per buffer_ (the previous code 
> grew or shrunk the entire frame).  I think per-buffer operation
> is far more useful (e.g., I currently have my Gnus article buffer
> resized up one step which is kind of pleasant; for viewing big
> files, resizing down a step or two is quite nice).

That is a definite advantage over the approach I use.

> The size calculations I'm using are the same as before -- a simple
> constant factor height scaling for each step -- and probably will
> occasionally miss a step on platforms with only non-scalable fonts and
> poor font size coverage.  With scalable fonts, however, this simple
> calculation works very well.
> 
> [Another issue with per-frame size changing was that very frequent
> changing of the default frame face tended to crash Emacs.  The whole
> baroque mechanism that gets invoked for that case is complicated and
> fragile.]

I don't see that, but perhaps it is platform-related. I'm using Windows. AFAICT,
it works fine and fast in Emacs 20 through 23.

> Another point is that the per-buffer mechanism is much faster 
> (even on a slow machine) -- frame-resize is _slow_ as well as being 
> flaky.  You can happily use auto-repeat... :-)

I don't see any slowdown either, but perhaps that too is platform-related. FWIW,
I use auto-repeat with frame-resizing all of the time. I use it not only to zoom
(via font) but also to change frame width and height.






  parent reply	other threads:[~2008-06-02 15:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 10:27 face-remapping-alist client code Miles Bader
2008-06-02 10:42 ` David Reitter
2008-06-02 10:45   ` Miles Bader
2008-06-02 13:13 ` Miles Bader
2008-06-02 14:19 ` Drew Adams
2008-06-02 14:44   ` Miles Bader
2008-06-02 14:50     ` Miles Bader
2008-06-02 15:09     ` Juanma Barranquero
2008-06-02 15:22       ` Miles Bader
2008-06-02 15:28         ` David Kastrup
2008-06-02 18:55           ` Stefan Monnier
2008-06-02 20:23             ` Drew Adams
2008-06-02 15:39         ` Juanma Barranquero
2008-06-02 18:54         ` Stefan Monnier
2008-06-02 15:56     ` Drew Adams [this message]
2008-06-02 15:09 ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001701c8c4c9$34db5880$c2b22382@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).