unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'David Kastrup'" <dak@gnu.org>
Cc: emacs-pretest-bug@gnu.org
Subject: RE: 23.0.60; kbd returns wrong value
Date: Sat, 17 May 2008 16:46:50 -0700	[thread overview]
Message-ID: <000a01c8b878$47627400$0200a8c0@us.oracle.com> (raw)
In-Reply-To: <002301c8b830$8930d900$0200a8c0@us.oracle.com>

> > >> After tracing edmacro-parse-keys, the problem seems to be here:
> > >>  
> > >> (while (and (< pos (length string))
> > >>   (string-match "[^ \t\n\f]+" string pos))
> > >>       (let ((word (substring string (match-beginning 0) 
> > >> (match-end 0)))
> > 
> > (string-match "[^ \t\n\f<]+\\|<[^>]+>" ... instead?
> 
> Yes, please install that fix; it seems to do the job. Thanks.

Actually, no, that breaks it for "C-x <", producing only "^X" (control-x
character).

The following regexp fixes that particular breakage: "[^
\t\n\f<]+\\|<[^>]+>\\|<+"

But that breaks other things. With input of "C-x <<>>", the output is [24 < 62].
With input of "C-x << >>", the output is [24 <\ 62]. In the vanilla code, e.g.,
the first produces [24 <>], and the second produces "^X<<>>" (control-x char),
which are presumably correct.

I have no idea what that is all about - there are no comments in the code wrt
what it is supposed to do with which inputs.

It would be good if someone who really understands `edmacro-parse-keys' would
please take a look and fix it as needed. And please add a doc string too.





  reply	other threads:[~2008-05-17 23:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 20:01 23.0.60; kbd returns wrong value Drew Adams
2008-05-16  7:14 ` Drew Adams
2008-05-16  9:32   ` David Kastrup
2008-05-17 15:13     ` Drew Adams
2008-05-17 23:46       ` Drew Adams [this message]
2008-05-18  0:00         ` Drew Adams
2008-05-18  3:12     ` Stefan Monnier
2008-05-18  5:32       ` Drew Adams
2008-05-18  9:26         ` More key strangeness (was: 23.0.60; kbd returns wrong value) David Kastrup
2008-05-19  8:20           ` More key strangeness Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000a01c8b878$47627400$0200a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=dak@gnu.org \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).