From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Sat, 12 Mar 2005 10:37:50 +0100 Message-ID: <000501c526e7$33a17f90$0200a8c0@sedrcw11488> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> <01c52655$Blat.v2.4$b47b9200@zahav.net.il> <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> <534dd629871884654f6c43846c34db9a@swipnet.se> <00f501c5266a$1bf72de0$0200a8c0@sedrcw11488> <01c5267c$Blat.v2.4$37bc1380@zahav.net.il> <010601c5269f$660e83d0$0200a8c0@sedrcw11488> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1110623625 8814 80.91.229.2 (12 Mar 2005 10:33:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2005 10:33:45 +0000 (UTC) Cc: hunterd42@comcast.net, Eli Zaretskii , kobayays@otsukakj.co.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 11:33:44 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DA3wA-0003AN-CO for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2005 11:33:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DA4BQ-0004ya-21 for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2005 05:49:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DA3ku-0005MK-En for emacs-devel@gnu.org; Sat, 12 Mar 2005 05:22:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DA3kn-0005Ke-VU for emacs-devel@gnu.org; Sat, 12 Mar 2005 05:21:55 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DA3kk-00058N-Hn for emacs-devel@gnu.org; Sat, 12 Mar 2005 05:21:51 -0500 Original-Received: from [81.228.9.107] (helo=av2-1-sn3.vrr.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DA34x-0005CT-Pk; Sat, 12 Mar 2005 04:38:41 -0500 Original-Received: by av2-1-sn3.vrr.skanova.net (Postfix, from userid 502) id 14BCE37E66; Sat, 12 Mar 2005 10:38:39 +0100 (CET) Original-Received: from smtp1-2-sn3.vrr.skanova.net (smtp1-2-sn3.vrr.skanova.net [81.228.9.178]) by av2-1-sn3.vrr.skanova.net (Postfix) with ESMTP id 0533037E55; Sat, 12 Mar 2005 10:38:39 +0100 (CET) Original-Received: from sedrcw11488 (t3o58p60.telia.com [195.252.56.60]) by smtp1-2-sn3.vrr.skanova.net (Postfix) with SMTP id 325E338008; Sat, 12 Mar 2005 10:38:36 +0100 (CET) Original-To: "Jason Rumney" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34506 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34506 ----- Original Message ----- From: "Jason Rumney" > "Lennart Borgman" writes: > > > I find it very hard to guess what this define is for without reading the > > code. Using names like HAVE_MOUSE, HAVE_HOURGLASS makes it much more easy to > > guess IMO. And I think that is important if you are scanning the code > > quickly trying to find things, see the structure etc. > > Conditional compilation constants are not comments. They are not there to > assist your reading of the code, they are there to enable that code > when appropriate. For that purpose, it is actually clearer to have the > constants named so that the conditions under which that code is > enabled is obvious. Having hourglass code surrounded by HAVE_HOURGLASS > is not adding anything, because the actual conditions under which > hourglass cursors are available depend on the platform, not some > configure test. Also someone debugging why hourglass cursors do > not work on a Mac might miss the fact that they are only enabled on X > and W32, that is not likely if we list the real conditions under which > that code is enabled. I do not think you can escape that the constant names have a comment purpose too. The names should of course be choosen so that it is as easy as possible to change and read the code. Constants like HAVE_WINDOW_SYSTEM, HAVE_MOUSE or HAVE_SOUND are currently set up by the configuration code.in config.in. I believed they had purposes hinted by their names. Maybe those names are misleading? Maybe it is bad practice and maybe those names should be removed? I actually can not see that they are used on w32 (just looking at config.h and makefile). I currently perhaps have some problems with the code submitted by Jan D for enabling hourglass when using "M-x indent-region". Hourglass is actually shown, but I wonder if I did something wrong since the messages about "10%" etc are not shown. I wonder if I missed some piece of the hourglass code somewhere? It would have been easier for me if that code had been surrounded by HAVE_HOURGLASS - if and only if (of course) the definition of HAVE_HOURGLASS was very clear. Can someone please tell me if the problem above exists on X Windows as well?