From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Ben Key" Newsgroups: gmane.emacs.devel Subject: RE: Updated patch for a Windows implementation of play-sound - 2 Date: Sat, 26 Oct 2002 00:47:57 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <000201c27caa$db78b240$6401a8c0@GODDESS> References: <200210251417.g9PEH5x20757@rum.cs.yale.edu> Reply-To: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1035608029 30613 80.91.224.249 (26 Oct 2002 04:53:49 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 26 Oct 2002 04:53:49 +0000 (UTC) Cc: Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 185IxH-0007xU-00 for ; Sat, 26 Oct 2002 06:53:47 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 185J0H-0007Jg-00 for ; Sat, 26 Oct 2002 06:56:53 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 185Iru-0000xF-00; Sat, 26 Oct 2002 00:48:14 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 185IrU-0000tL-00 for emacs-devel@gnu.org; Sat, 26 Oct 2002 00:47:48 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 185IrR-0000sP-00 for emacs-devel@gnu.org; Sat, 26 Oct 2002 00:47:47 -0400 Original-Received: from smtp-server1.tampabay.rr.com ([65.32.1.34]) by monty-python.gnu.org with esmtp (Exim 4.10) id 185IrR-0000ri-00 for emacs-devel@gnu.org; Sat, 26 Oct 2002 00:47:45 -0400 Original-Received: from GODDESS (6535194hfc48.tampabay.rr.com [65.35.194.48]) by smtp-server1.tampabay.rr.com (8.12.2/8.12.2) with SMTP id g9Q4lhMl027133; Sat, 26 Oct 2002 00:47:43 -0400 (EDT) Original-To: "'Stefan Monnier'" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook CWS, Build 9.0.2416 (9.0.2911.0) In-Reply-To: <200210251417.g9PEH5x20757@rum.cs.yale.edu> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 Importance: Normal Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8798 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8798 > Oh and the "normal" #ifdef style used in Emacs is: > > #if FOO > #else /* !FOO */ > #endif /* !FOO */ > or > #if FOO > #endif /* FOO */ I find this style of #ifdef blocks to be much too cryptic for my tastes. What does /* !FOO */ and /* FOO */ mean anyway. I find that it is much clearer if your comments for the #else and #endif portions state exactly what #ifdef line they go to rather than some cryptic reference to what they go to. This style causes much less confusion and is a great help when you are not really reading the code in detail but are just skimming through looking for the place where you need to make a change. This is one of the few places where my coding style differs from the GNU coding standards. I would like to thank you for testing this patch on Linux. I have not yet had a chance to do so myself. I still do not have my Linux machine up and running completely. I am now trying to get Samba to work on it properly.