From: "Ben Key" <Bkey1@tampabay.rr.com>
Cc: <emacs-devel@gnu.org>
Subject: RE: Updated patch for a Windows implementation of play-sound - 2
Date: Sat, 26 Oct 2002 00:47:57 -0400 [thread overview]
Message-ID: <000201c27caa$db78b240$6401a8c0@GODDESS> (raw)
In-Reply-To: <200210251417.g9PEH5x20757@rum.cs.yale.edu>
> Oh and the "normal" #ifdef style used in Emacs is:
>
> #if FOO
> #else /* !FOO */
> #endif /* !FOO */
> or
> #if FOO
> #endif /* FOO */
I find this style of #ifdef blocks to be much too cryptic for my tastes.
What does /* !FOO */ and /* FOO */ mean anyway. I find that it is much
clearer if your comments for the #else and #endif portions state exactly
what #ifdef line they go to rather than some cryptic reference to what they
go to. This style causes much less confusion and is a great help when you
are not really reading the code in detail but are just skimming through
looking for the place where you need to make a change.
This is one of the few places where my coding style differs from the GNU
coding standards.
I would like to thank you for testing this patch on Linux. I have not yet
had a chance to do so myself. I still do not have my Linux machine up and
running completely. I am now trying to get Samba to work on it properly.
next prev parent reply other threads:[~2002-10-26 4:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-25 5:03 Updated patch for a Windows implementation of play-sound - 2 Ben Key
2002-10-25 14:17 ` Stefan Monnier
2002-10-26 4:47 ` Ben Key [this message]
2002-10-26 12:39 ` Kai Großjohann
2002-10-27 23:38 ` Richard Stallman
2002-10-27 23:37 ` Richard Stallman
2002-10-28 1:13 ` Ben Key
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201c27caa$db78b240$6401a8c0@GODDESS' \
--to=bkey1@tampabay.rr.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).