From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: master bd86a6c4fde: perl-mode.el: Improve indent after hanging open-paren Date: Mon, 08 Jul 2024 10:10:42 +0000 Message-ID: <-xZojRvSzmkBcEdk0mTp6I-Es1d82WDp9-mm_vR6Qu9cWcm4D8LJMkZIxs_i22PI04mAMSeC1zsVZl0brK49l1NWF4aljJEXh27fZ1D6kHM=@protonmail.com> References: <172018816877.20149.12049864165694613040@vcs2.savannah.gnu.org> <20240705140249.2BC2DC1F9F8@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_aLrW2I32PFWP4VS2r5UPDDK0W6KJo6c9fkjn2aXevc" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21566"; mail-complaints-to="usenet@ciao.gmane.io" To: Emacs Devel , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 08 13:03:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQm9T-0005Kt-Ja for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jul 2024 13:03:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQm8Q-0008KD-JN; Mon, 08 Jul 2024 07:02:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQlKk-0004y5-TZ for emacs-devel@gnu.org; Mon, 08 Jul 2024 06:10:58 -0400 Original-Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQlKi-0005Wa-PD for emacs-devel@gnu.org; Mon, 08 Jul 2024 06:10:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720433446; x=1720692646; bh=bpHfhQxBP3tVfADZpP23ctbh6wZiVOFTL0YefVpqeEE=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=hz+b2MsY5KgRsQSBelbnMjzl0LYkZgN+ofijs6oY9cYC/7u+1NeXfjc0XkTmpjF8G ErJ92ag0dkwWkwWChOUfNHmZjm8sNo9JQ9wi94IExqLFdwcGVIUAuL1ojbaOMPumAX 3q8cm5IGy95SeUQulNRq0G/V2+VKfJSeX3xlq1/SrvbQNTIq3oeAVs/2cYglQSJnHD AIrH7IFE8O0jWHBMHGnKQarngiGXHmyU7Lsvq5BJ0ig/O9swCWJM5ofRTTAaZOPg0x kJrJe2//Iz82iUcpGlXFijGC0SyMAokhZeL9Rq1WyDyLrzktop9AYJuVTjwo47168F qE15VlzE2+Ulg== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: ed8a5cc9ca889ea384b954cde6391634669362da Received-SPF: pass client-ip=185.70.43.22; envelope-from=pipcet@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 08 Jul 2024 07:02:15 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321535 Archived-At: This is a multi-part message in MIME format. --b1_aLrW2I32PFWP4VS2r5UPDDK0W6KJo6c9fkjn2aXevc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > On Friday, July 5th, 2024 at 14:02, Stefan Monnier via Mailing list for E= macs changes emacs-diffs@gnu.org wrote: >=20 > > branch: master > > commit bd86a6c4fde1aa42ea9e8b5434f0cb63f8d52684 > > Author: Stefan Monnier monnier@iro.umontreal.ca > >=20 > > Commit: Stefan Monnier monnier@iro.umontreal.ca > >=20 > > perl-mode.el: Improve indent after hanging open-paren > >=20 > > Make the indentation of the code right after an open paren/brace > > use the same rule as already used to indent the corresponding > > matching paren/brace. > >=20 > > * lisp/progmodes/perl-mode.el (perl-calculate-indent): > > Use `perl-indent-new-calculate`s "virtual" indentation instead of > > approximating it with `current-indentation`. Sorry, I sent this to Stefan but not to emacs-devel...=20 Is it possible this causes a test failure in cperl-test-bug-64364? It does = appear to do so here, and the new indentation behavior seems weird to me (t= hough I'm not using Perl much anymore, so maybe this is the New Way). =20 I believe the attached patch might restore the intended behavior... Pip --b1_aLrW2I32PFWP4VS2r5UPDDK0W6KJo6c9fkjn2aXevc Content-Type: text/x-patch; name=0001-perl-indent.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-perl-indent.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3BlcmwtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVz L3BlcmwtbW9kZS5lbAppbmRleCBmZjcxOTcwZDQxYi4uMTNkNWQ3Zjk0NTEgMTAwNjQ0Ci0tLSBh L2xpc3AvcHJvZ21vZGVzL3BlcmwtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wZXJsLW1v ZGUuZWwKQEAgLTExMjgsOCArMTEyOCw4IEBAIHBlcmwtY2FsY3VsYXRlLWluZGVudAogICAgICAg ICAgICAgOzsgTW92ZSBiYWNrIG92ZXIgd2hpdGVzcGFjZSBiZWZvcmUgdGhlIG9wZW5icmFjZS4K ICAgICAgICAgICAgIDs7IElmIG9wZW5icmFjZSBpcyBub3QgZmlyc3Qgbm9ud2hpdGUgdGhpbmcg b24gdGhlIGxpbmUsCiAgICAgICAgICAgICA7OyBhZGQgdGhlIHBlcmwtYnJhY2UtaW1hZ2luYXJ5 LW9mZnNldC4KLSAgICAgICAgICAgIChwcm9nbiAoc2tpcC1jaGFycy1iYWNrd2FyZCAiIFx0IikK LSAgICAgICAgICAgICAgICAgICAoaWYgKGJvbHApIDAgcGVybC1icmFjZS1pbWFnaW5hcnktb2Zm c2V0KSkKKyAgICAgICAgICAgIChzYXZlLWV4Y3Vyc2lvbiAoc2tpcC1jaGFycy1iYWNrd2FyZCAi IFx0IikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGJvbHApIDAgcGVybC1icmFj ZS1pbWFnaW5hcnktb2Zmc2V0KSkKICAgICAgICAgICAgIChwZXJsLWluZGVudC1uZXctY2FsY3Vs YXRlICd2aXJ0dWFsKSkpKSkpKSkKIAogKGRlZnVuIHBlcmwtYmFja3dhcmQtdG8tbm9uY29tbWVu dCAoKQo= --b1_aLrW2I32PFWP4VS2r5UPDDK0W6KJo6c9fkjn2aXevc--