From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode Date: Sat, 25 May 2024 02:35:42 +0000 Message-ID: References: <868r0ajh5j.fsf@gnu.org> <86bk55iw54.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39347"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 70939@debbugs.gnu.org To: Ankit Gadiya Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 04:37:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAhHX-000A3e-QR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 04:37:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAhHF-0001dw-GE; Fri, 24 May 2024 22:36:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAhHD-0001dH-EQ for bug-gnu-emacs@gnu.org; Fri, 24 May 2024 22:36:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAhHD-0006ra-5y for bug-gnu-emacs@gnu.org; Fri, 24 May 2024 22:36:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAhHK-0000yG-7P for bug-gnu-emacs@gnu.org; Fri, 24 May 2024 22:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 02:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70939 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70939-submit@debbugs.gnu.org id=B70939.17166045643715 (code B ref 70939); Sat, 25 May 2024 02:37:02 +0000 Original-Received: (at 70939) by debbugs.gnu.org; 25 May 2024 02:36:04 +0000 Original-Received: from localhost ([127.0.0.1]:40458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAhGO-0000xr-3j for submit@debbugs.gnu.org; Fri, 24 May 2024 22:36:04 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:48149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAhGK-0000xS-DT for 70939@debbugs.gnu.org; Fri, 24 May 2024 22:36:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1716604546; x=1716863746; bh=2WBSbuXfbOMoRD/gTMRS+zgCcvxfmgQvBKc2JD2TaR0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=i3a4J71jm6VkFyfFIHxWPO0EEtpwjx/GYJa5cW17JV6FZDo2V0Is+1K4Ma0TfNb/X 8EiKkcJdACWohzP76J+6W+quobv3FLbGAOOhxleBadKBAtzJLcNM7YeZiGKvsy1xTx s/5AP3uQB4BUOU6zHJCE6sMAcBbYU/K2Y9MqZHp8qmc3ybc9zOPmecDRpERjxy/5/p g1deveuqOzDJp7vEne6FwJmt9XFzL4VQhlcxRsi1JL8+oIIbjVHL6QGSy5bynvP0+3 UMrfPlRgn1dGLDE2QxPdQowRGdz32BrnGnMZoEev3Qf+I5baagtaI5oWOQMJBxwS51 +htNFEiVyduOg== In-Reply-To: Feedback-ID: 44397038:user:proton X-Pm-Message-ID: c6f09e1b47b1bd754105ba1ebad01d840f8683a6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285807 Archived-At: On Saturday, May 18th, 2024 at 05:54, Ankit Gadiya via "Bug reports for GNU= Emacs, the Swiss army knife of text editors" wrote= : >=20 > [...] >=20 > I'm submitting an updated Patch with the following changes: > * Add commit log > * Fix the text formatting. > * Update the keybindings to use the C-c C-t prefix. > * Improve regexp matching to be more strict. > * Define =3Dgo-ts-mode-build-tags=3D variable in the module and use it in= the test > functions. >=20 > -- > Ankit Thanks. Sorry for the delay in reviewing, I've been having internet troubles since = last Friday. I'll take a look at this next week. A few quick things I noticed on a glance: + (let* ((node (go-ts-mode--find-defun-at start)) +=09 (name (treesit-defun-name node)) Indentation is off on the name line - looks like a TAB was used? Should onl= y be spaces everywhere. Double check the rest is OK. +region. It is bound to 'C-c C-t' in 'go-ts-mode'. ^ C-c C-t t +package of the current buffer. It is bound to 'C-c C-p' in 'go-ts-mode'. ^ C-c C-t p + "List of go build tags for the test commands." ^ Go + "Return a list with names of all defuns in the range." We should probably say what the range actually is (START to END) - not sure= if we have a convention for that wording already.